fix(rust): Restore symbols on Apple by bumping nightly version#20563
Merged
fix(rust): Restore symbols on Apple by bumping nightly version#20563
Conversation
Member
|
You need to run clippy and fix the new lints. |
Contributor
|
The uncompressed lib size after this PR is 1116.9641 MB. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20563 +/- ##
==========================================
- Coverage 78.98% 78.98% -0.01%
==========================================
Files 1564 1564
Lines 220759 220738 -21
Branches 2504 2504
==========================================
- Hits 174363 174341 -22
- Misses 45822 45823 +1
Partials 574 574 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Function symbols were being stripped from release builds on Apple due to a bug in the Rust compiler, this was fixed recently in rust-lang/rust#135034.
Having symbols in the final shipped binary does make it slightly larger, but makes diagnosing performance issues/bugs on released Polars versions significantly easier. Note that this is only the function names for non-inlined functions, it does not keep all the other debug information.