Draft
Conversation
Collaborator
|
Very nice. Is there a way we can test this without going live on master, yet? |
Collaborator
Author
We can test it locally and build the wheel, after doing a Depending on the outputs of flake8, we can relax some of the conditions. There will be several warnings that can be ignored, if we choose to do so. A reference list of errors and warnings here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces linting standards for Neuromancer.
How to use:
Setup
then to run pre-commit with the hooks on a single file:
or, on all files:
This will obviously change most of the files in the repository, so we can definitely expect a one-time big change in everything.