Skip to content

Port the RFC SILK output resampler #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zshang-oai wants to merge 1 commit into
base: master
Choose a base branch
from

Port SILK output resampler

469fda8
Select commit
Loading
Failed to load commit list.
Open

Port the RFC SILK output resampler #93

Port SILK output resampler
469fda8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 27, 2026 in 0s

78.98% (+2.66%) compared to 10397d9

View this Pull Request on Codecov

78.98% (+2.66%) compared to 10397d9

Details

Codecov Report

❌ Patch coverage is 84.13043% with 73 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.98%. Comparing base (10397d9) to head (469fda8).

Files with missing lines Patch % Lines
decoder.go 82.73% 15 Missing and 9 partials ⚠️
internal/resample/silk/down_fir.go 75.26% 23 Missing ⚠️
internal/resample/silk/resampler.go 83.19% 17 Missing and 3 partials ⚠️
internal/resample/silk/fixed.go 71.42% 3 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage   76.32%   78.98%   +2.66%     
==========================================
  Files           8       13       +5     
  Lines        1246     1680     +434     
==========================================
+ Hits          951     1327     +376     
- Misses        264      310      +46     
- Partials       31       43      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov