Update AWS Lambda reference in asynchronous docs#2413
Open
urbanautomaton wants to merge 1 commit intopinojs:mainfrom
Open
Update AWS Lambda reference in asynchronous docs#2413urbanautomaton wants to merge 1 commit intopinojs:mainfrom
urbanautomaton wants to merge 1 commit intopinojs:mainfrom
Conversation
Since [this commit](1) it's no longer true that pino automatically logs synchronously in AWS Lambda. This updates the docs to reflect that, adjusting the advice to match the reference to sync destinations in the linked commit. [1]: e1c9528
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This docs page currently advises that in AWS Lambda environments, synchronous output is automatically enabled. However, since this commit that's no longer true.
This updates the docs accordingly, adjusting the advice to match the reference to sync destinations in the linked commit.
Feedback
I'm not particularly expert with Pino; is the updated advice appropriate? I've removed the reference to
flushSync()since it appeared from the linked commit that sync destinations were the preferred approach, but should this still be mentioned as an alternative option?