feat: add pino.raw() for serializers#2393
Open
DemianParkhomenko wants to merge 1 commit intopinojs:mainfrom
Open
feat: add pino.raw() for serializers#2393DemianParkhomenko wants to merge 1 commit intopinojs:mainfrom
pino.raw() for serializers#2393DemianParkhomenko wants to merge 1 commit intopinojs:mainfrom
Conversation
mcollina
reviewed
Feb 12, 2026
| } | ||
|
|
||
| function stringify (obj, stringifySafeFn) { | ||
| if (obj !== null && typeof obj === 'object' && rawJSONSym in obj) { |
Member
There was a problem hiding this comment.
can you just keep the last check?
Author
There was a problem hiding this comment.
We need all checks to avoid a TypeError https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/in_operator_no_object
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #1846