Conversation
9d794d3 to
57587c9
Compare
|
@jaredgoldman this ready for serious review? |
|
@goodboy I think we're ready for some more testing |
|
@algorandpa seems like i can only stage order with |
|
@jaredgoldman as mentioned in chat as well we've got some kinda strange thing going on with trade rate calcs:
yeah so if you look at how we (currently) implement the trade rate, it's basically just counting the number of vlm-containing-trades (aka clears):
my guess is somehow we've got a tick being generated by ur backend code that's fitting into the See https://github.com/pikers/piker/blob/master/piker/fsp/_volume.py#L162 for the filter loop. hopefully that helps to start digging, if not we can resume in chat 👍🏼 |
Add Kucoin backend client wip
yes, if you want to in this PR it's fine by me. currently we something like:
|
goodboy
left a comment
There was a problem hiding this comment.
@jaredgoldman other then a couple more suggestions that I don't think you need to change right now in this PR (particularly bc i just had to entirely rework open_autiorecon_ws() in #489 😂) and this little bit of linting i was still able to catch:
I think this is more then ready to land!
Great work yet again and glad to see our backend crypto set expanding using trio native machnery 🏄🏼
Only last thing is please move all the outstanding todo tasks and follow up into another issue that links to this one before you merge this.
Other then that please merge at your leisure 🐶
|
excellent work yet again compadre 🏄🏼 nice follow up issue and final linting before getting this in ma dawg! |



This PR includes a brokerd module for Kucoin's api. So far, only code for market data has been implemented. This includes:
Remaining tasks for full support are detailed in #499