Upgrade to veewee/xml v4 and bump minimum PHP to 8.4#22
Merged
Conversation
- Bumps veewee/xml from ^3.0 to ^4.9 (new PHP 8.4 spec-compliant DOM API) - Drops PHP 8.3 support; minimum is now ~8.4.0 || ~8.5.0 - Removes PHP 8.3 from all GitHub Actions matrices - Updates Psalm phpVersion to 8.4 and adds DOM stubs from veewee/xml 4.8+ - Migrates DOMDocument/DOMElement/DOMNode to Dom\XMLDocument/Dom\Element/Dom\Node - Adapts Loader interface: __invoke() now returns XMLDocument instead of mutating one - Adapts Mapper interface: parameter is now Dom\XMLDocument - Replaces Document::configure(loader(...)) with Document::fromLoader(...) in XmlMessageManipulator - Updates all expectAllOfType() calls to use Dom\Element::class
veewee
force-pushed
the
upgrade/veewee-xml-v4
branch
from
8a6f80a to
64637ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
veewee/xmlfrom^3.0to^4.9(uses PHP 8.4's new spec-compliantDom\API)~8.4.0 || ~8.5.0phpVersionto8.4and adds DOM stubs fromveewee/xml4.8+Migration changes
Psr7StreamLoader: updated to newLoaderinterface (__invoke(): XMLDocumentinstead of mutating a passedDOMDocument)Psr7StreamMapper: updated to newMapperinterface (parameter is nowDom\XMLDocument)XmlMessageManipulator: replacedDocument::configure(loader(...))withDocument::fromLoader(...)DOMDocument/DOMElement/DOMNodetype hints replaced withDom\XMLDocument/Dom\Element/Dom\NodeexpectAllOfType(DOMElement::class)calls updated toexpectAllOfType(Element::class)Test plan
docphpro/php84— PHP 8.4.19, libxml 2.9.14 on Ubuntu 24.04)