Add basic event support for setting events#881
Open
hernanmd wants to merge 26 commits intopharo-spec:Pharo13from
Open
Add basic event support for setting events#881hernanmd wants to merge 26 commits intopharo-spec:Pharo13from
hernanmd wants to merge 26 commits intopharo-spec:Pharo13from
Conversation
…claration. Announce SettingUpdated on checkboxes only if the setting effectively changed. Fix checkboxes items always opening with the default value instead of the real value. Add announcer support in StSettingPresenterItem
jecisc
reviewed
Nov 7, 2024
… settingTree already present in the application's properties. Announce SettingUpdated on checkboxes only if the setting effectively changed. Fix checkboxes items always opening with the default value instead of the real value.
Member
|
Simple registration of updated events for now.
Add tests. Use 1-arg blocks for announcing updates.
Add confirm question before overwriting system settings.
…ion because cannot reproduce the bug in the image)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes
This PR needs pharo-project/pharo#17350 to be integrated in the Pharo image
Details
Introduces the following updates: