Introducing new scoped based on matching patterns#19394
Merged
Ducasse merged 4 commits intopharo-project:Pharo14from Mar 16, 2026
Merged
Introducing new scoped based on matching patterns#19394Ducasse merged 4 commits intopharo-project:Pharo14from
Ducasse merged 4 commits intopharo-project:Pharo14from
Conversation
To improve scope precision we implemented with @DurieuxPol matching package name scopes based on the '-'. It let the user choose which things he wants to seek/change more easily. Needs 1 test to check the behavior on a refactoring Fixes pharo-project#19005.
Member
|
dionisiydk
reviewed
Mar 8, 2026
dionisiydk
reviewed
Mar 8, 2026
src/Calypso-SystemTools-FullBrowser/ClyFullBrowserMorph.class.st
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
@dionisiydk I made changes based on your review, you made a great point. |
AlexisCnockaert
added a commit
to AlexisCnockaert/NewTools
that referenced
this pull request
Mar 9, 2026
These tests validate 3 behaviours: filtering based on prefix, `=`, and `hash` which are reimplemented on this new package. (The PR for this new scope is pharo-project/pharo#19394)
Collaborator
Author
|
pharo-spec/NewTools#1353 for the tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To improve scope precision we implemented with @DurieuxPol matching package name scopes based on the '-'. It let the user choose which things he wants to seek/change more easily. Needs test to check the behavior on a refactoring (at least that these new scopes are passed to the driver
Fixes #19005.