Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions api/apiv1/design/common.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@ import (
)

var Identifier = g.Type("Identifier", g.String, func() {
g.Description("A user-specified identifier. Must be 1-63 characters, contain only lower-cased letters and hyphens, start and end with a letter or number, and not contain consecutive hyphens.")
g.Description("A user-specified identifier. Must be 1-36 characters, contain only lower-cased letters and hyphens, start and end with a letter or number, and not contain consecutive hyphens.")
// Intentionally not using a pattern here for two reasons:
// - Go regex doesn't support lookahead, so we can't express the consecutive
// hyphen rule.
// - The pattern is somewhat complex, so the error message is hard to
// interpret when the value doesn't match.
g.MinLength(1)
g.MaxLength(63)
g.MaxLength(36)
Comment thread
coderabbitai[bot] marked this conversation as resolved.
g.Example("Human-readable", func() {
g.Description("Identifiers can be human-readable for ease of use.")
g.Value("production")
Expand Down
2 changes: 1 addition & 1 deletion api/apiv1/gen/control_plane/service.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

116 changes: 58 additions & 58 deletions api/apiv1/gen/http/control_plane/client/cli.go

Large diffs are not rendered by default.

48 changes: 24 additions & 24 deletions api/apiv1/gen/http/control_plane/client/types.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading