Fix #2561: Escape control characters in assertion error messages#2690
Draft
nohwnd wants to merge 1 commit intopester:mainfrom
Draft
Fix #2561: Escape control characters in assertion error messages#2690nohwnd wants to merge 1 commit intopester:mainfrom
nohwnd wants to merge 1 commit intopester:mainfrom
Conversation
nohwnd
commented
Apr 3, 2026
Comment on lines
+56
to
+64
| $Value = $Value ` | ||
| -replace "`0", '␀' ` | ||
| -replace "`a", '␇' ` | ||
| -replace "`b", '␈' ` | ||
| -replace "`t", '␉' ` | ||
| -replace "`f", '␌' ` | ||
| -replace "`r", '␍' ` | ||
| -replace "`n", '␊' ` | ||
| -replace "`e", '␛' |
Member
Author
There was a problem hiding this comment.
feels like we are re-constructing the same string so many times this way, we should have some similar code that does this by prepenting the code point with a bit that makes it visible. and does that via string builder and a loop. basically re-building the whole string just once.
Member
Author
There was a problem hiding this comment.
special chars are uncommon, so this should be as cheap as possible.
Format-String2 now escapes control characters as Unicode control pictures so they are visible in error messages. Characters like ESC (used in ANSI sequences) now display as their Unicode symbol instead of being invisible. Copilot-generated fix. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
nohwnd
force-pushed
the
fix-2561-escape-chars
branch
from
af6075c to
1d213ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2561
Format-String2 now escapes control characters as Unicode control pictures so they are visible in error messages. Characters like ESC (used in ANSI sequences) now display as their Unicode symbol instead of being invisible.
Copilot-generated fix.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com