PMM-12832 Timeouts for exporters. by JiriCtvrtka · Pull Request #5134 · percona/pmm

JiriCtvrtka · 2026-03-12T08:37:50Z

PMM-12832

FB: Percona-Lab/pmm-submodules#4275

Summary

Add support for configuring custom connection timeout for exporters
Apply the configured timeout consistently across supported exporter types, including RDS and Azure flows
Ensure generated MySQL and PostgreSQL config/DSN values handle whole-second timeout requirements correctly
New default for exporter is increased from 1 second to 2 seconds

managed/models/agent_model.go

…PMM-12832-exporter-timeouts

Copilot

Pull request overview

Copilot reviewed 104 out of 105 changed files in this pull request and generated 1 comment.

Copilot · 2026-04-08T08:52:52Z

managed/utils/duration/duration.go

+// FromProto converts a protobuf Duration to a time.Duration.
+func FromProto(d *durationpb.Duration) time.Duration {
+	if d == nil {
+		return 0
+	}
+
+	return d.AsDuration()


FromProto returns d.AsDuration() without validating the protobuf Duration or guarding against time.Duration overflow. A user can provide a very large (but protobuf-valid) duration that overflows time.Duration and becomes a negative/small value, leading to incorrect exporter timeouts. Consider validating (CheckValid) and adding an explicit upper bound / overflow-safe conversion (reject or clamp values that can’t fit into time.Duration).

@copilot d.CheckValid() is already done in pb files.

maxkondr · 2026-04-09T13:46:27Z

managed/models/agent_helpers.go

+		if params.ExporterOptions.ConnectionTimeout != nil {
+			if pointer.GetDuration(params.ExporterOptions.ConnectionTimeout) == 0 {
+				row.ExporterOptions.ConnectionTimeout = nil
+			} else {
+				row.ExporterOptions.ConnectionTimeout = params.ExporterOptions.ConnectionTimeout
+			}
+		}


Suggested change

if params.ExporterOptions.ConnectionTimeout != nil {

if pointer.GetDuration(params.ExporterOptions.ConnectionTimeout) == 0 {

row.ExporterOptions.ConnectionTimeout = nil

} else {

row.ExporterOptions.ConnectionTimeout = params.ExporterOptions.ConnectionTimeout

}

}

if params.ExporterOptions.ConnectionTimeout != nil {

row.ExporterOptions.ConnectionTimeout = params.ExporterOptions.ConnectionTimeout

}

maxkondr · 2026-04-09T13:51:34Z

managed/models/agent_model.go

 }

+// EffectiveDialTimeout returns the timeout configured for this agent's exporter.
+// Only for exporters that have connection timeout support in DSN/config generation.


looks confusing- for exporters that don't support timeout in DSN/config it returns default constant that may be treated as supported timeout

maxkondr · 2026-04-09T14:00:07Z

managed/services/agents/mongodb.go

 	}
 	env := []string{
-		fmt.Sprintf("MONGODB_URI=%s", exporter.DSN(service, models.DSNParams{DialTimeout: time.Second, Database: database}, tdp, pmmAgentVersion)),
+		fmt.Sprintf("MONGODB_URI=%s", exporter.DSN(service, models.DSNParams{DialTimeout: exporter.EffectiveDialTimeout(), Database: database}, tdp, pmmAgentVersion)),


what about the rest of Mongo Agents (QAN, RTA)? They support timeout in DSN as well

Yes, other non exporters agents support timeouts too, but scope in ticket is about exporters only.

maxkondr · 2026-04-09T14:04:46Z

managed/services/agents/postgresql.go

+	case exporter.AzureOptions.ClientID != "":
+		if pointer.GetDuration(exporter.ExporterOptions.ConnectionTimeout) != 0 {
+			roundedConnectionTimeout = *exporter.ExporterOptions.ConnectionTimeout
+		} else {
+			roundedConnectionTimeout = postgresRemoteCloudDefaultDialTimeout
+		}
+	case node.NodeType == models.RemoteRDSNodeType:
+		if pointer.GetDuration(exporter.ExporterOptions.ConnectionTimeout) != 0 {
+			roundedConnectionTimeout = *exporter.ExporterOptions.ConnectionTimeout
+		} else {
+			roundedConnectionTimeout = postgresRemoteCloudDefaultDialTimeout
+		}
+	default:
+		roundedConnectionTimeout = exporter.EffectiveDialTimeout()


Suggested change

case exporter.AzureOptions.ClientID != "":

if pointer.GetDuration(exporter.ExporterOptions.ConnectionTimeout) != 0 {

roundedConnectionTimeout = *exporter.ExporterOptions.ConnectionTimeout

} else {

roundedConnectionTimeout = postgresRemoteCloudDefaultDialTimeout

}

case node.NodeType == models.RemoteRDSNodeType:

if pointer.GetDuration(exporter.ExporterOptions.ConnectionTimeout) != 0 {

roundedConnectionTimeout = *exporter.ExporterOptions.ConnectionTimeout

} else {

roundedConnectionTimeout = postgresRemoteCloudDefaultDialTimeout

}

default:

roundedConnectionTimeout = exporter.EffectiveDialTimeout()

case exporter.AzureOptions.ClientID != "",

node.NodeType == models.RemoteRDSNodeType:

if pointer.GetDuration(exporter.ExporterOptions.ConnectionTimeout) != 0 {

roundedConnectionTimeout = *exporter.ExporterOptions.ConnectionTimeout

} else {

roundedConnectionTimeout = postgresRemoteCloudDefaultDialTimeout

}

default:

roundedConnectionTimeout = exporter.EffectiveDialTimeout()

maxkondr · 2026-04-09T14:08:43Z

managed/services/agents/valkey.go

+	connectionTimeout := exporter.ExporterOptions.ConnectionTimeout
+	if pointer.GetDuration(connectionTimeout) == 0 {
+		connectionTimeout = pointer.ToDuration(defaultValkeyTimeout)
+	}


Suggested change

}

connectionTimeout := &defaultValkeyTimeout

if pointer.GetDuration(exporter.ExporterOptions.ConnectionTimeout) != 0 {

connectionTimeout = exporter.ExporterOptions.ConnectionTimeout

}

maxkondr · 2026-04-09T14:11:40Z

managed/services/agents/valkey.go

in general: there are many places where pointer.GetDuration(exporterOptions.ConnectionTimeout) is used.
Q: if we have validation on API level gte:0 it means here on service/model level there can be either exporterOptions.ConnectionTimeout == nil or exporterOptions.ConnectionTimeout > 0. So is there any reason to use pointer.GetDuration() at all?

maxkondr · 2026-04-09T14:21:47Z

managed/services/inventory/agents.go

+		return nil
+	}
+
+	return pointer.ToDuration(d.AsDuration())


btw, there is shorter generic method pointer.To[T any](t T) *T that returns pointer to passed type

Not sure which one is "faster" but changed, because yes it is shorter and simpler to read.

maxkondr · 2026-04-09T14:23:57Z

managed/services/inventory/agents.go

 	}
 }

+func optionalDurationFromProto(d *durationpb.Duration) *time.Duration {


move to managed/utils/duration ?

Moved to utils.

maxkondr · 2026-04-09T14:26:05Z

managed/services/management/azure_database.go

 				ServiceID:    service.ServiceID,
 				AzureOptions: models.AzureOptionsFromRequest(req),
+				ExporterOptions: models.ExporterOptions{
+					ConnectionTimeout: pointer.ToDuration(duration.FromProto(req.ConnectionTimeout)),


optionalDurationFromProto ?

I wonder why some Create* funds receive ConnectionTimeout *time.Duration but others ConnectionTimeout time.Duration

Yeah right. It was used for inventory. So I moved it from inventory to utils (like you requested even here PMM-12832 Timeouts for exporters. #5134 (comment)) and right now it is used also in management everywhere.

My fault and inconsistency. Fixed

ademidoff · 2026-04-10T11:00:02Z

api/inventory/v1/agents.proto

  LogLevel log_level = 5;
  // Expose the node_exporter process on all public interfaces
  bool expose_exporter = 6;
+  // Connection timeout for exporter (if set).


If I'm not wrong, the validation below will disallow me to skip the connection timeout, right?

ademidoff · 2026-04-10T15:54:18Z

managed/models/agent_model_test.go

+				ConnectionTimeout: &custom,
+			},
+		}
+		assert.Equal(t, custom, a.EffectiveDialTimeout())


I think we should only use assert in very rare cases, where we want the test to continue running. In this particular case and downwards, IMO we should use require.

ademidoff · 2026-04-10T16:00:07Z

managed/services/agents/postgresql.go

-	if node.NodeType == models.RemoteRDSNodeType {
-		dsnParams.DialTimeout = 5 * time.Second
-	}
+	var roundedConnectionTimeout time.Duration


Suggested change

var roundedConnectionTimeout time.Duration

var connectionTimeout time.Duration

I'd keep it short and simple :)

PMM-12832 Rough implementation.

d01d2da

github-code-quality bot found potential problems Mar 12, 2026

View reviewed changes

managed/models/agent_model.go Fixed Show fixed Hide fixed

JiriCtvrtka and others added 28 commits March 12, 2026 09:49

PMM-12832 Fix.

ca36e37

Merge branch 'v3' into PMM-12832-exporter-timeouts

eb9dc4e

PMM-12832 More exporters, refactor.

342e4c0

Merge remote-tracking branch 'origin/PMM-12832-exporter-timeouts' into …

75c0854

…PMM-12832-exporter-timeouts

PMM-12832 Another parts.

e009b06

PMM-12832 Mongo change, list.

fe76cec

PMM-12832 Changes, refactor.

3dd7cb4

PMM-12832 Refactor of agent model.

3831afd

PMM-12832 Lint.

27895b3

PMM-12832 Inventory timeout for all.

dad3e75

Merge branch 'v3' into PMM-12832-exporter-timeouts

64d37ca

PMM-12832 Add change func after merge.

d1c530e

PMM-12832 Fix for now.

3c358f0

PMM-12832 Changes.

658fc92

PMM-12832 Fix tests.

58db609

PMM-12832 Changes.

b3d65c7

PMM-12832 Changes.

8f44fc6

PMM-12832 Changes.

c329c2a

PMM-12832 Changes.

1b924cd

PMM-12832 Change for RTA.

098d50e

PMM-12832 Fix.

5811d1b

PMM-12832 Fix.

42f5b86

PMM-12832 Fix.

69ed781

PMM-12832 Refactor.

bccea8d

PMM-12832 Remove not related types.

80226ed

PMM-12832 Changes.

c6dd6e7

PMM-12832 Remote, valkey, etc.

963a998

PMM-12832 Fix.

4e09994

This comment was marked as resolved.

Sign in to view

PMM-12832 Round timeout value for PG.

d82da03

JiriCtvrtka requested a review from Copilot April 7, 2026 17:02

Copilot started reviewing on behalf of JiriCtvrtka April 7, 2026 17:03 View session

This comment was marked as outdated.

Sign in to view

PMM-12832 Lint.

6f87420

JiriCtvrtka requested a review from Copilot April 7, 2026 18:33

Copilot started reviewing on behalf of JiriCtvrtka April 7, 2026 18:34 View session

This comment was marked as resolved.

Sign in to view

JiriCtvrtka added 2 commits April 8, 2026 10:11

PMM-12832 Better comment.

f5a9fd7

PMM-12832 Shared method for Node, External, Azure and RDS exporter.

b3dc97b

JiriCtvrtka requested a review from Copilot April 8, 2026 08:23

Copilot started reviewing on behalf of JiriCtvrtka April 8, 2026 08:24 View session

This comment was marked as outdated.

Sign in to view

JiriCtvrtka added 2 commits April 8, 2026 10:44

PMM-12832 More precise description for connection timeout flag.

518b33c

Merge branch 'v3' into PMM-12832-exporter-timeouts

5ec76de

JiriCtvrtka requested a review from Copilot April 8, 2026 08:45

Copilot started reviewing on behalf of JiriCtvrtka April 8, 2026 08:46 View session

Copilot AI reviewed Apr 8, 2026

View reviewed changes

JiriCtvrtka requested review from ademidoff and maxkondr April 8, 2026 18:25

maxkondr reviewed Apr 9, 2026

View reviewed changes

JiriCtvrtka added 4 commits April 10, 2026 10:56

PMM-12832 Flags from string to duration.

61f05f9

PMM-12832 Duration helper moved to utils.

5d8ea95

PMM-12832 All creates has connection timeouts passed as pointers.

d707ce9

PMM-12832 Use generic method for pointer.

b34943b

ademidoff reviewed Apr 10, 2026

View reviewed changes

PMM-12832 Remove unnecessary checks.

9f20473

ademidoff reviewed Apr 10, 2026

View reviewed changes

-	}
+	connectionTimeout := &defaultValkeyTimeout
+	if pointer.GetDuration(exporter.ExporterOptions.ConnectionTimeout) != 0 {
+		connectionTimeout = exporter.ExporterOptions.ConnectionTimeout
+	}

	var roundedConnectionTimeout time.Duration
	var connectionTimeout time.Duration

Conversation

JiriCtvrtka commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

JiriCtvrtka Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

JiriCtvrtka commented Mar 12, 2026 •

edited

Loading

JiriCtvrtka Apr 8, 2026 •

edited

Loading