Draft
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- Settings: Add Adre struct (Enabled, URL), IsAdreEnabled(), GetAdreURL() - ChangeSettingsParams: Add EnableAdre, AdreURL for updates - New package managed/services/adre: HolmesGPT HTTP client - Models(), Chat(), ChatStream(), Investigate(), InvestigateStream() - Uses HolmesGPT /api/chat, /api/stream/chat, /api/investigate, etc. Made-with: Cursor
- Introduced new HTTP handlers for ADRE settings, models, chat, alerts, and investigation endpoints in the pmm-managed service. - Updated the Grafana auth server to include permissions for ADRE routes. - Added navigation support for ADRE in the UI, including a dedicated page and chat widget. - Enhanced the main application layout to incorporate the ADRE chat widget. Made-with: Cursor
theTibi
requested review from
JiriCtvrtka,
fabio-silva,
matejkubinec and
maxkondr
and removed request for
a team
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## tibi-test #5118 +/- ##
=============================================
- Coverage 47.57% 46.61% -0.96%
=============================================
Files 414 553 +139
Lines 42177 44876 +2699
Branches 0 658 +658
=============================================
+ Hits 20065 20920 +855
- Misses 20134 21890 +1756
- Partials 1978 2066 +88
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Modified README to clarify ADRE settings access for viewers and admins. - Enhanced ChatStream functionality to handle streaming requests more effectively. - Added URL validation in PostSettings handler to ensure proper format. - Updated Grafana auth server to allow viewer access to ADRE settings. - Improved error handling in AdrePage to manage loading states and forbidden access. - Refactored AdreChatWidget to remove unused model fetching logic. - Introduced a utility function to parse and extract text from SSE data in chat streams. Made-with: Cursor
- Updated README to specify that alerts require ADRE to be enabled. - Modified ChatStream to avoid mutating the original request. - Added comprehensive tests for ADRE settings and model retrieval. - Improved URL validation in PostSettings handler to ensure proper format and provide clearer error messages. - Enhanced error handling in various ADRE handlers to ensure consistent responses. Made-with: Cursor
- Changed the ChatStream HTTP request URL from /api/stream/chat to /api/chat for consistency. - Enhanced error message formatting in ChatStream to clarify the source of errors related to the new endpoint. Made-with: Cursor
- Updated ADRE handlers to fetch alerts from Grafana's Alertmanager instead of VMAlert. - Modified README to reflect the change in alert source. - Enhanced error handling and added tests for the new alert fetching functionality. - Refactored related components to improve clarity and maintainability. Made-with: Cursor
- Added support for Basic Authentication in the ADRE client by encoding credentials in the Authorization header. - Updated README to include instructions for using authentication with HolmesGPT URLs. - Improved error handling in the InvestigateStream method to clarify endpoint usage. Made-with: Cursor
- Updated the buildInvestigatePayload function to include optional context and subject fields as records. - Improved the structure of the subject field to encapsulate alert details more effectively. - Ensured that the context field provides additional information about the alert source and count. Made-with: Cursor
…handling - Updated adreChatStream to accept a callback for both content and reasoning chunks, improving the response structure. - Refactored SSE data parsing to return content and reasoning separately, enhancing clarity and usability. - Modified AdreChatPanel to store and display reasoning alongside chat messages, improving user experience. - Improved local storage handling to accommodate reasoning data, ensuring persistence across sessions. Made-with: Cursor
- Changed the default chat mode from "fast" to "investigation" across various components, including settings, chat panel, and preferences. - Updated the logic in the settings model and UI to reflect this change, ensuring consistency in user experience. - Introduced utility functions for loading and saving chat UI preferences, enhancing user configurability. - Adjusted related tests to verify the correct handling of the new default chat mode. These changes improve the alignment of the ADRE feature with user expectations and enhance the overall chat experience.
Resolve conflicts: keep AI investigations migrations 130-133; add syslog preset as 134; SSO table drop as 135; renumber rta_options migration 126->116 to match tibi-test. Merge ADRE and OTEL retention settings, defaults, and tests. Keep PMM 2 client deprecation note in upgrade docs. Made-with: Cursor
- Implemented a new endpoint `/v1/adre/qan-insights/servicenow` to handle POST requests for creating ServiceNow tickets based on QAN insights. - Enhanced the `ChatRequest` structure to include new fields for frontend tools and decisions. - Updated the investigation response to include confidence metrics and evidence entries. - Added functionality to copy investigation details in markdown and JSON formats from the Investigation Detail Page. - Improved the QAN AI Insights page with a button to create ServiceNow tickets and display the ticket number upon creation. This update enhances the integration of QAN insights with ServiceNow, providing users with better tools for incident management.
- Added a new binary file `pmm-managed-linux` for managing PMM operations. - Updated the `GetQanInsights` handler to return a 200 status with an empty analysis and `cached: false` on cache misses, improving user experience by avoiding misleading 404 errors. - Removed the ServiceNow ticket creation functionality from the QAN AI Insights page, streamlining the interface. - Introduced new utility functions for managing frontend tools, ensuring compatibility with legacy tool names and enhancing the overall user interaction with PMM. - Improved the layout and responsiveness of the Adre page components, ensuring better usability across different screen sizes. This update enhances the QAN insights functionality and user interface, providing a more intuitive experience for users interacting with PMM.
Made-with: Cursor
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 5.5.2 to 6.0.0. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v5.5.2...57e3a13) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-version: 6.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [docker/login-action](https://github.com/docker/login-action) from 4.0.0 to 4.1.0. - [Release notes](https://github.com/docker/login-action/releases) - [Commits](docker/login-action@b45d80f...4907a6d) --- updated-dependencies: - dependency-name: docker/login-action dependency-version: 4.1.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…5217) Agent-Logs-Url: https://github.com/percona/pmm/sessions/dc400a49-230f-400c-a20e-a4f893760826 Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ademidoff <81549+ademidoff@users.noreply.github.com> Co-authored-by: Alex Demidoff <alexander.demidoff@percona.com>
* Follow up on PR review * chore: trigger the build * Fix a broken link
…agent - Introduced `daemonset.example.yaml` as a reference for deploying the coroot-node-agent in Kubernetes, including configuration for security context, resource limits, and volume mounts. - Added a README file to provide guidance on using the coroot-node-agent with PMM, detailing installation steps, configuration options, and best practices for deployment. - Enhanced documentation for OTEL ClickHouse schema alignment and rollout strategies, ensuring clarity on database management and schema creation.
Contributor
|
|
…ations - Introduced a new interactive service map panel for PMM, visualizing service connections and synchronized trace data. - Added configuration files including ESLint and TypeScript settings for the new panel. - Created a comprehensive README detailing features, data sources, build, and deployment instructions. - Implemented various components for the service map, including namespace filtering and service node representation. - Updated .gitignore to include build artifacts for the new panel. This commit lays the foundation for enhanced observability in PMM through the service map visualization.
- Enhanced GitHub Actions workflow to include caching for both pmm-app and pmm-service-map dependencies. - Updated Grafana configuration to allow loading of the new pmm-service-map-panel plugin. - Incremented RPM release version to 24 and included the pmm-service-map-panel in the percona-dashboards RPM. - Modified Makefile to install and build dependencies for both pmm-app and pmm-service-map. - Updated the OTel ClickHouse dashboard JSON to use the new ClickHouse-OTEL datasource. - Revised README for the pmm-service-map to clarify deployment instructions within PMM. These changes improve the integration and deployment of the new service map panel, enhancing observability in PMM.
- Introduced a new AI Insights tab in the Details section, allowing users to access AI-generated analysis for queries. - Implemented the AiInsights component to handle fetching and displaying insights, including loading states and error handling. - Added constants and messages for the new tab, including various user notifications and actions. - Created a service for API interactions related to AI insights, including fetching insights and creating ServiceNow tickets. - Updated the Details component to integrate the new AI Insights tab and manage its visibility based on query context. These changes enhance the user experience by providing actionable insights directly within the PMM interface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PMM-0
Link to the Feature Build: SUBMODULES-0
If this PR adds, removes or alters one or more API endpoints, please review and add or update the relevant API documentation as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: