Replaced deploymentName with deployment.name in SRS chart#835
Open
alemax22 wants to merge 79 commits intopegasystems:masterfrom
Open
Replaced deploymentName with deployment.name in SRS chart#835alemax22 wants to merge 79 commits intopegasystems:masterfrom
alemax22 wants to merge 79 commits intopegasystems:masterfrom
Conversation
…cumentation and updated unit tests
Collaborator
|
@pegasystems/searchservice Can you please review the changes |
Contributor
|
@reddy-srinivas Could you please take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The key deploymentName in the SRS chart was replaced with the key deployment.name in order to be aligned to the style of all the other charts. The implementation maintains backward compatibility, in particular: the deploymentName (marked as deprecated) key has precedence over the new key deployment.name. A specific unit test was designed to assure this behaviour.
All the other unit tests and the documentation were updated.