Allow GHES repository to support deploy key#680
Open
jiminj wants to merge 2 commits intopeaceiris:mainfrom
Open
Allow GHES repository to support deploy key#680jiminj wants to merge 2 commits intopeaceiris:mainfrom
jiminj wants to merge 2 commits intopeaceiris:mainfrom
Conversation
Author
|
BTW, I have another fix related to #579 (comment). Will make another PR once this is resolved. |
|
@peaceiris it would be nice to have this fix incorporated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a revision of #679, allowing to deploy on GHES repositories using deploy keys. - Found that simple error code checking does not handle the case when
ssh-keyscanis failed. this PR includes the updated logic and corresponding test codes.Tested with the GHES server with self-hosted runners, and github.com. You can test it by using
uses: jiminj/actions-gh-pages@v3.8.1-0