Skip to content

OCTO-11450-fix-breaks-accumulate-across-caption-boundaries#364

Merged
OlteanuRares merged 3 commits intomainfrom
OCTO-11450
Apr 23, 2026
Merged

OCTO-11450-fix-breaks-accumulate-across-caption-boundaries#364
OlteanuRares merged 3 commits intomainfrom
OCTO-11450

Conversation

@OlteanuRares
Copy link
Copy Markdown
Contributor

@OlteanuRares OlteanuRares commented Apr 14, 2026

No description provided.

@OlteanuRares OlteanuRares requested a review from a team as a code owner April 14, 2026 13:51
@OlteanuRares
Copy link
Copy Markdown
Contributor Author

OlteanuRares commented Apr 14, 2026

Files Changed:

  • pycaption/scc/state_machines.py: Added reset method
  • pycaption/scc/init.py: Added 6 reset calls at boundaries
  • tests/test_scc.py: Updated test expectations
  • tests/fixtures/dfxp.py: Updated fixture outputs

Impact:

  • ✅ All 51 tests passing
  • ✅ Full CEA-608 specification compliance
  • ✅ 463 DFXP and 326 VTT improvements across 10 analyzed test cases
  • ✅ 0 regressions detected

dianadersedan
dianadersedan previously approved these changes Apr 14, 2026
View reviewed changes
panasicov
panasicov previously approved these changes Apr 14, 2026
View reviewed changes
lorandvarga
lorandvarga reviewed Apr 15, 2026
View reviewed changes
Comment thread pycaption/dfxp/base.py Outdated
lorandvarga
lorandvarga reviewed Apr 15, 2026
View reviewed changes
Comment thread pycaption/scc/constants.py Outdated
lorandvarga
lorandvarga reviewed Apr 15, 2026
View reviewed changes
Comment thread pycaption/scc/constants.py Outdated
lorandvarga
lorandvarga reviewed Apr 15, 2026
View reviewed changes
Comment thread pycaption/scc/constants.py Outdated
lorandvarga
lorandvarga reviewed Apr 15, 2026
View reviewed changes
Comment thread pycaption/scc/constants.py Outdated
lorandvarga
lorandvarga reviewed Apr 15, 2026
View reviewed changes
Comment thread pycaption/scc/constants.py Outdated
lorandvarga
lorandvarga reviewed Apr 15, 2026
View reviewed changes
Comment thread pycaption/scc/constants.py Outdated
lorandvarga
lorandvarga requested changes Apr 15, 2026
View reviewed changes
Comment thread pycaption/scc/constants.py Outdated
Comment thread pycaption/scc/constants.py Outdated
Comment thread pycaption/scc/constants.py Outdated
Comment thread pycaption/scc/constants.py Outdated
Comment thread pycaption/scc/constants.py Outdated
Comment thread pycaption/scc/constants.py Outdated
Comment thread pycaption/scc/constants.py Outdated
Comment thread pycaption/geometry.py Outdated
Comment thread pycaption/geometry.py Outdated
Comment thread pycaption/geometry.py Outdated
lorandvarga
lorandvarga reviewed Apr 15, 2026
View reviewed changes
Comment thread docs/conf.py Outdated
lorandvarga
lorandvarga reviewed Apr 15, 2026
View reviewed changes
Comment thread tests/test_webvtt.py Outdated
lorandvarga
lorandvarga reviewed Apr 15, 2026
View reviewed changes
Comment thread tests/test_webvtt.py Outdated
lorandvarga
lorandvarga reviewed Apr 15, 2026
View reviewed changes
Comment thread tests/test_webvtt.py Outdated
@OlteanuRares OlteanuRares dismissed stale reviews from panasicov and dianadersedan via ba0c7a3 April 17, 2026 07:26
lorandvarga
lorandvarga previously approved these changes Apr 21, 2026
View reviewed changes
@OlteanuRares OlteanuRares merged commit 77d82d7 into main Apr 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lorandvarga lorandvarga lorandvarga approved these changes

@dianadersedan dianadersedan dianadersedan left review comments

@panasicov panasicov panasicov left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@OlteanuRares @lorandvarga @dianadersedan @panasicov