Merged
Conversation
meeuw
force-pushed
the
replace-glob1-with-glob
branch
3 times, most recently
from
0efa3b8 to
53bd7a0
Compare
meeuw
force-pushed
the
replace-glob1-with-glob
branch
from
53bd7a0 to
1632613
Compare
lucc
approved these changes
Apr 7, 2026
Collaborator
|
@pazz I did a quick check and this seems to work. Was there an original reason to use glob1 instead of glob or pathlib.Path.glob? |
Owner
|
Quoting Lucas Hoffmann ***@***.***) at 2026-04-07 06:15:18
@pazz I did a quick check and this seems to work.
\o/
Was there an original reason to use glob1 instead of glob or pathlib.Path.glob?
I don't remember, sorry.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1712
As glob.glob1 is undocumented and it's not so clear to me why it was used in the first place I'm not 100% sure if this fix is right.