Skip to content

Use connect-go and connect-web for APIs #1664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
metalmatze wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Use connect-go and connect-web for APIs #1664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0097304
Delete gRPC gateway files
metalmatze Mar 28, 2023
4a2cef3
gen/proto/swagger: Remove swagger generated json files
metalmatze Mar 28, 2023
01b0c16
proto: Generate connect-go and connect-es/connect-web files
metalmatze Mar 28, 2023
f6c82a5
Update go.mod with connect-go
metalmatze Mar 28, 2023
fdae96c
pkg: Move all gRPC servers to connect-go
metalmatze Mar 29, 2023
c39d9e9
ui/packages: Start using connectweb on targets page
metalmatze Mar 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions buf.gen.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@ plugins:
out: gen/proto/go
opt: paths=source_relative

# renovate: datasource=github-releases depName=bufbuild/connect-go
- plugin: connect-go
Copy link
Member

@maxbrunet maxbrunet Mar 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aliases! I'd still pin the version of the plugins to ensure it is reproducible

out: gen/proto/go
opt: paths=source_relative

# renovate: datasource=github-releases depName=planetscale/vtprotobuf
- plugin: buf.build/community/planetscale-vtprotobuf:v0.4.0
out: gen/proto/go
Expand All @@ -25,15 +30,14 @@ plugins:
- long_type_string
- generate_dependencies

# renovate: datasource=github-releases depName=grpc-ecosystem/grpc-gateway
- plugin: buf.build/grpc-ecosystem/gateway:v2.15.2
out: gen/proto/go
# renovate: datasource=github-releases depName=bufbuild/connect-es
- plugin: es
out: ui/packages/shared/client/src
opt:
- paths=source_relative
- generate_unbound_methods=true
- target=ts

# renovate: datasource=github-releases depName=grpc-ecosystem/grpc-gateway
- plugin: buf.build/grpc-ecosystem/openapiv2:v2.15.2
out: gen/proto/swagger
# renovate: datasource=github-releases depName=bufbuild/connect-web
- plugin: connect-web
out: ui/packages/shared/client/src
opt:
- allow_merge=false
- target=ts
1 change: 0 additions & 1 deletion gen/.gitignore
View file
Open in desktop

This file was deleted.

229 changes: 0 additions & 229 deletions gen/proto/go/grpc/health/v1/health.pb.gw.go
View file
Open in desktop

This file was deleted.

Loading