feat(engine): log elapsed time for completed workunits#22992
Open
jasonwbarnett wants to merge 2 commits intopantsbuild:mainfrom
Open
feat(engine): log elapsed time for completed workunits#22992jasonwbarnett wants to merge 2 commits intopantsbuild:mainfrom
jasonwbarnett wants to merge 2 commits intopantsbuild:mainfrom
Conversation
When a workunit completes, the log message now includes how long it took. For example: "Completed: Generate lockfile for foo (12.34s)" For operations taking 60 seconds or more, the format shows minutes: "Completed: Build target (2m 30.0s)" Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
jasonwbarnett
force-pushed
the
jwb/log-workunit-duration
branch
2 times, most recently
from
a16c307 to
0983a6a
Compare
benjyw
reviewed
Jan 9, 2026
Contributor
benjyw
left a comment
benjyw
left a comment
There was a problem hiding this comment.
Thanks for the contribution! See comments.
src/rust/workunit_store/src/lib.rs
Outdated
| (WorkunitState::Completed { .. }, _) => "Completed:", | ||
| }; | ||
|
|
||
| // Format duration for completed workunits (not canceled ones) |
Contributor
There was a problem hiding this comment.
This comment is superfluous (typical of LLM-generated code). It just restates what the code below it clearly does...
src/rust/workunit_store/src/lib.rs
Outdated
| let duration_str = if !canceled { | ||
| if let WorkunitState::Completed { time_span } = &self.state { | ||
| format_workunit_duration(std::time::Duration::from(time_span.duration)) | ||
| } else { |
Contributor
There was a problem hiding this comment.
Why not show duration of incomplete workunits too?
src/rust/workunit_store/src/lib.rs
Outdated
| String::new() | ||
| } | ||
| } else { | ||
| String::new() |
Contributor
There was a problem hiding this comment.
Seems weird to allocate a superfluous empty String for this. Better to use an Option and the format can use something like duration_str.as_ref().unwrap_or("")
Contributor
|
@jasonwbarnett this partially implements this idea: #11965 |
jasonwbarnett
force-pushed
the
jwb/log-workunit-duration
branch
from
0983a6a to
2248d22
Compare
Extract format_workunit_duration into a standalone function and add comprehensive unit tests covering: - Sub-second durations - Durations under 60 seconds - Boundary case at exactly 60 seconds - Durations with minutes and seconds - Zero duration Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
jasonwbarnett
force-pushed
the
jwb/log-workunit-duration
branch
from
2248d22 to
c58d943
Compare
benjyw
reviewed
Jan 13, 2026
| WorkunitState::Completed { time_span } => { | ||
| Some(format_workunit_duration(std::time::Duration::from(time_span.duration))) | ||
| } | ||
| WorkunitState::Started { start_time, .. } if canceled => { |
Contributor
There was a problem hiding this comment.
So you only show the elapsed time if the work was canceled? Why? Wouldn't the opposite make more sense? Or just always show it?
Contributor
|
Hi, just checking in on the status of this... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When Pants completes a workunit (like generating a lockfile), the log message only shows that it completed, not how long it took:
This makes it difficult to identify slow operations or track performance over time.
Solution
Log the elapsed time alongside the completion message:
For longer operations (60+ seconds), show minutes:
Implementation
format_workunit_duration()helper function insrc/rust/workunit_store/src/lib.rslog_workunit_state()to include duration for completed (non-canceled) workunitsCloses #22991