[FIX]: clear view binding references in onDestroyView to prevent memory…#4814
Open
corevibe555 wants to merge 1 commit intoowncloud:masterfrom
Open
[FIX]: clear view binding references in onDestroyView to prevent memory…#4814corevibe555 wants to merge 1 commit intoowncloud:masterfrom
corevibe555 wants to merge 1 commit intoowncloud:masterfrom
Conversation
Author
|
@joragua Here is another small PR. Thanks! |
Collaborator
|
Thanks for the contribution @corevibe555! 🙌🏻 I will check this PR as soon as possible and give you any feedback if necessary. Stay tuned! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes #4813
Description
Set
_binding = nullinonDestroyView()for 10 fragments that were missing cleanup, preventing memory leaks when fragment instances outlive their views.Affected fragments:
CreateShortcutDialogFragmentFileDetailsFragmentMainEmptyListFragmentRemoveFilesDialogFragmentSharesFragmentSpacesListFragmentCreateSpaceDialogFragmentAddMemberFragmentSpaceMembersFragmentSetSpaceIconDialogFragmentApp:
ReleaseNotesViewModel.ktcreating a newReleaseNote()with String resources (if required)QA