Open
Conversation
revert some unnecessary formatting changes microtask mode
Contributor
Author
|
I noticed promise rejections are not handled properly in VMs either, but that is outside the scope of this PR. If anyone wants to see the issue update the test script with this and run with node/bun: Node handles the rejection but Bun silently ignores it. I might fix that just not in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes this issue: #20145
How did you verify your code works?
Has a test, requires using my patched WebKit so that will need to be merged before merging this.
See WebKit PR here: oven-sh/WebKit#101