[FSSDK-11372] assign holdoutIds to feature flags#578
Merged
muzahidul-opti merged 25 commits intomasterfrom Apr 21, 2025
Merged
Conversation
* master: [FSSDK-11371] parsing holdout section from the datafile (#577) # Conflicts: # Sources/Data Model/ExperimentCore.swift # Sources/Data Model/Holdout.swift
muzahidul-opti
changed the title
jaeopt
requested changes
Apr 8, 2025
Contributor
jaeopt
left a comment
jaeopt
left a comment
There was a problem hiding this comment.
Looks good! Let's discuss options.
muzahidul-opti
commented
Apr 9, 2025
jaeopt
requested changes
Apr 10, 2025
Contributor
jaeopt
left a comment
jaeopt
left a comment
There was a problem hiding this comment.
Looks good. We need to add order enforcement as discussed.
muzahidul-opti
commented
Apr 15, 2025
jaeopt
requested changes
Apr 15, 2025
Contributor
jaeopt
left a comment
jaeopt
left a comment
There was a problem hiding this comment.
I like the change. It looks like we need to fix ordering.
Contributor
Author
|
jaeopt
requested changes
Apr 17, 2025
Contributor
jaeopt
left a comment
jaeopt
left a comment
There was a problem hiding this comment.
Changes looks good! A few more clean up tips.
Co-authored-by: Jae Kim <45045038+jaeopt@users.noreply.github.com>
muzahidul-opti
added a commit
that referenced
this pull request
May 29, 2025
* master: Experiment id and variation id added into decision notification payload (#589) [FSSDK-11374] add test cases for impression event and decision listener with holdout support (#588) [FSSDK-11373] add holdout support and refactor decision logic in DefaultDecisionService (#587) [FSSDK-11372] assign holdoutIds to feature flags (#578) [FSSDK-11371] parsing holdout section from the datafile (#577) [FSSDK-11111] chore: update cocoapods version (#576) [FSSDK-11102] chore: replace travis-ci-tools repository (#571)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Issues