Skip to content

✨ fix(boxcutter): cache Secrets only in olmv1-system namespace to ensure better performance #2609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
camilamacedo86 wants to merge 1 commit into from
Closed

✨ fix(boxcutter): cache Secrets only in olmv1-system namespace to ensure better performance #2609

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions cmd/operator-controller/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import (

"github.com/spf13/cobra"
"go.podman.io/image/v5/types"
corev1 "k8s.io/api/core/v1"
rbacv1 "k8s.io/api/rbac/v1"
apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
apiextensionsv1client "k8s.io/apiextensions-apiserver/pkg/client/clientset/clientset/typed/apiextensions/v1"
Expand Down Expand Up @@ -283,6 +284,18 @@ func run() error {
return err
}

// Ensure bundle Secrets in the configured systemNamespace are cached without enabling a cluster-wide Secret informer.
// Bundle Secrets are created in cfg.systemNamespace by SecretPacker.
if secretCache, ok := cacheOptions.ByObject[&corev1.Secret{}]; ok {
if secretCache.Namespaces == nil {
secretCache.Namespaces = make(map[string]crcache.Config)
}
if _, exists := secretCache.Namespaces[cfg.systemNamespace]; !exists {
secretCache.Namespaces[cfg.systemNamespace] = crcache.Config{}
}
cacheOptions.ByObject[&corev1.Secret{}] = secretCache
}
Comment on lines +287 to +297
Copy link
Copy Markdown
Member

@joelanford joelanford Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already cache everything in the system namespace, don't we? See lines 259-261.


metricsServerOptions := server.Options{}
if len(cfg.certFile) > 0 && len(cfg.keyFile) > 0 {
setupLog.Info("Starting metrics server with TLS enabled", "addr", cfg.metricsAddr, "tls-cert", cfg.certFile, "tls-key", cfg.keyFile)
Expand Down
Loading