Skip to content

Add support for RTL strings#68

Merged
benoit74 merged 4 commits intomainfrom
rtl_support
Mar 24, 2026
Merged

Add support for RTL strings#68
benoit74 merged 4 commits intomainfrom
rtl_support

Conversation

@benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Mar 24, 2026

Fix #54

Changes:

  • download RTL plugin in scraper thanks to openzim.toml / hatch-openzim mechanisms ; use RTL plugin in UI JS

Other changes:

  • Move from --assets to --dl to stop confusion with the assets folder present in the scraper source code
    • include simplification of ZIM files layout: all assets from assets folder are placed in assets path in the ZIM
  • Fix issues around favicon

@benoit74 benoit74 self-assigned this Mar 24, 2026
@codecov
Copy link

codecov bot commented Mar 24, 2026

Codecov Report

❌ Patch coverage is 5.26316% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.07%. Comparing base (f888537) to head (1f2f6e0).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
scraper/src/maps2zim/processor.py 5.55% 34 Missing ⚠️
scraper/src/maps2zim/entrypoint.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
- Coverage   32.10%   32.07%   -0.03%     
==========================================
  Files          11       11              
  Lines         978      982       +4     
  Branches      131      132       +1     
==========================================
+ Hits          314      315       +1     
- Misses        653      656       +3     
  Partials       11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benoit74 benoit74 merged commit 93c0314 into main Mar 24, 2026
10 checks passed
@benoit74 benoit74 deleted the rtl_support branch March 24, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maps that has an arabic language, the arabic names is written wrong

1 participant