Skip to content

Linux 7.0: autoconf: Remove copy-from-user-inatomic API checks (#18348)#18354

Merged
tonyhutter merged 1 commit intoopenzfs:masterfrom
john-cabaj:john-cabaj/remove-old-copy_from_user_inatomic-checks
Mar 23, 2026
Merged

Linux 7.0: autoconf: Remove copy-from-user-inatomic API checks (#18348)#18354
tonyhutter merged 1 commit intoopenzfs:masterfrom
john-cabaj:john-cabaj/remove-old-copy_from_user_inatomic-checks

Conversation

@john-cabaj
Copy link
Contributor

@john-cabaj john-cabaj commented Mar 19, 2026

This function was removed in c6442bd: "Removing old code outside of 4.18 kernsls", but fails at present on PowerPC builds due to the recent inclusion of 6bc9c0a90522: "powerpc: fix KUAP warning in VMX usercopy path" in the upstream kernel, which introduces a use of cpu_feature_keys[], which is a GPL-only symbol. Removing the API check as it doesn't appear necessary.

Motivation and Context

This solves a failure to build the module on PowerPC detailed here - #18348

Description

The check for the copy-from-user-inatomic API is simply removed

How Has This Been Tested?

Changes have been tested on base amd64 system, and the modules now build successfully on PowerPC.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Quality assurance (non-breaking change which makes the code more robust against bugs)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@john-cabaj john-cabaj force-pushed the john-cabaj/remove-old-copy_from_user_inatomic-checks branch 2 times, most recently from ad2a04e to cf982ae Compare March 19, 2026 21:17
@john-cabaj john-cabaj changed the title Linux 7.0: autoconf: Removing checks for copy-from-user-inatomic API (#18348) Linux 7.0: autoconf: Remove copy-from-user-inatomic API checks (#18348) Mar 19, 2026
…fs#18348)

This function was removed in c6442bd: "Removing old code outside
of 4.18 kernsls", but fails at present on PowerPC builds due to the
recent inclusion of 6bc9c0a90522: "powerpc: fix KUAP warning in VMX
usercopy path" in the upstream kernel, which introduces a use of
cpu_feature_keys[], which is a GPL-only symbol. Removing the API
check as it doesn't appear necessary.

Signed-off-by: John Cabaj <john.cabaj@canonical.com>
@john-cabaj john-cabaj force-pushed the john-cabaj/remove-old-copy_from_user_inatomic-checks branch from cf982ae to 4a58866 Compare March 19, 2026 21:24
Copy link
Member

@robn robn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I never liked this one.

@amotin amotin added the Status: Accepted Ready to integrate (reviewed, tested) label Mar 23, 2026
@amotin amotin linked an issue Mar 23, 2026 that may be closed by this pull request
@tonyhutter tonyhutter merged commit 8518e3e into openzfs:master Mar 23, 2026
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Accepted Ready to integrate (reviewed, tested)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

configure fails on ppc with v7.0-rc4

4 participants