Skip to content

attendedsysupgrade-common: shorten Makefile description#29062

Merged
aparcar merged 1 commit intoopenwrt:masterfrom
owlsy:attended-makefile
Apr 5, 2026
Merged

attendedsysupgrade-common: shorten Makefile description#29062
aparcar merged 1 commit intoopenwrt:masterfrom
owlsy:attended-makefile

Conversation

@owlsy
Copy link
Copy Markdown
Contributor

@owlsy owlsy commented Apr 4, 2026

📦 Package Details

Maintainer: @aparcar

Description:
Changes made to Makefile, no changes to package itself.

  • Current description is getting cut off and formatted incorrectly in LuCI when viewing packages.
  • Rewrote description to shorten, correct and provide a more concise description that will work in LuCI.

Before:
Screenshot 2026-04-04 at 11 50 51 pm

After:
Screenshot 2026-04-04 at 11 52 08 pm


🧪 Run Testing Details

  • OpenWrt Version: LuCI openwrt-25.12 branch (26.090.82136~bee369c) / OpenWrt 25.12.2 (r32802-f505120278)
  • OpenWrt Target/Subtarget: Not applicable
  • OpenWrt Device: Not applicable

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

@owlsy owlsy changed the title attendedsysupgrade-common: Update Makefile desc attendedsysupgrade-common: update Makefile description Apr 4, 2026
@owlsy owlsy force-pushed the attended-makefile branch from 9a4571b to 8349b77 Compare April 4, 2026 13:12
@owlsy owlsy changed the title attendedsysupgrade-common: update Makefile description attendedsysupgrade-common: shorten Makefile description Apr 4, 2026
@aparcar
Copy link
Copy Markdown
Member

aparcar commented Apr 4, 2026

Thanks for your contribution. Please increase the package version when modifying the package, else the same package version results in different package hashes

@owlsy
Copy link
Copy Markdown
Contributor Author

owlsy commented Apr 4, 2026

Thanks @aparcar!

Will do, I wasn't sure if I needed to if it was just the Makefile.

It is currently just version 9. Are we able to make it 9.0.1 or should it just be bumped up to 10?

@aparcar
Copy link
Copy Markdown
Member

aparcar commented Apr 5, 2026

10, thanks

Current description is getting
cut off and is formatted incorrectly
in LuCI when viewing packages.
Rewrote description to shorten,
correct and provide a more
concise description that will
work in LuCI.

Signed-off-by: Joshua Criss <owlsy@outlook.com.au>
@owlsy owlsy force-pushed the attended-makefile branch from 8349b77 to 83ffe9b Compare April 5, 2026 06:31
@owlsy
Copy link
Copy Markdown
Contributor Author

owlsy commented Apr 5, 2026

No worries, should all be good now to go ahead.

@aparcar aparcar merged commit 2b817a4 into openwrt:master Apr 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants