Allow conversion of `std::process::Command` into a `openssh::Command` given a `openssh::Session`.#112

Merged

NobodyXu merged 27 commits into

openssh-rust:masterfrom

aalekhpatel07:master

Jul 28, 2023

Commits on Jul 28, 2023

Add OverSsh trait to allow conversion of std::process::Command into a openssh::Session.

aalekhpatel07
authored and
NobodyXu
committed
Add a doc comment and example usage.

aalekhpatel07
authored and
NobodyXu
committed
Add tests for OverSsh's with_session

aalekhpatel07
authored and
NobodyXu
committed
Use raw_command and raw_args. Refactor the name to 'over_ssh'.

aalekhpatel07
authored and
NobodyXu
committed
Remove a dangling test import. Use better name for test.

aalekhpatel07
authored and
NobodyXu
committed
Clean up doc comment.

aalekhpatel07
authored and
NobodyXu
committed
Apply suggestions of code review.

aalekhpatel07
authored and
NobodyXu
committed
Update src/command.rs

aalekhpatel07
and
NobodyXu
committed
Apply more suggestions from the code review.

aalekhpatel07
authored and
NobodyXu
committed
Apply more suggestions from the code review.

aalekhpatel07
authored and
NobodyXu
committed
Update src/command.rs

aalekhpatel07
and
NobodyXu
committed
Update src/lib.rs

aalekhpatel07
and
NobodyXu
committed
Update src/escape.rs

aalekhpatel07
and
NobodyXu
committed
Apply more suggestions. Add a test for non-utf8 chars for escape.

aalekhpatel07
authored and
NobodyXu
committed
Slight refactor of escape.

CdnCentreForChildProtection
authored and
NobodyXu
committed
Run cargo clippy --fix and persist all modifications to escape.rs

CdnCentreForChildProtection
authored and
NobodyXu
committed
Apply rustfmt to command.rs and escape.rs

CdnCentreForChildProtection
authored and
NobodyXu
committed
Lint over_session test

CdnCentreForChildProtection
authored and
NobodyXu
committed
Update src/escape.rs

aalekhpatel07
and
NobodyXu
committed
Update src/escape.rs

aalekhpatel07
and
NobodyXu
committed
Update src/escape.rs

aalekhpatel07
and
NobodyXu
committed
Apply more suggestions.

aalekhpatel07
authored and
NobodyXu
committed
Rustfmt fix.

aalekhpatel07
authored and
NobodyXu
committed
Fix a doctest for overssh.

aalekhpatel07
authored and
NobodyXu
committed
Add a test for overssh that requires escaping the argument passed to the command.

aalekhpatel07
authored and
NobodyXu
committed
Update overssh require-escaping-arguments test to contain a space.

aalekhpatel07
authored and
NobodyXu
committed
Apply rustfmt to tests/openssh.rs

aalekhpatel07
authored and
NobodyXu
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow conversion of `std::process::Command` into a `openssh::Command` given a `openssh::Session`.#112

Allow conversion of `std::process::Command` into a `openssh::Command` given a `openssh::Session`.#112
NobodyXu merged 27 commits into
openssh-rust:masterfrom
aalekhpatel07:master

Commits on Jul 28, 2023

Add OverSsh trait to allow conversion of std::process::Command into a openssh::Session.

Add a doc comment and example usage.

Add tests for OverSsh's with_session

Use raw_command and raw_args. Refactor the name to 'over_ssh'.

Remove a dangling test import. Use better name for test.

Clean up doc comment.

Apply suggestions of code review.

Update src/command.rs

Apply more suggestions from the code review.

Apply more suggestions from the code review.

Update src/command.rs

Update src/lib.rs

Update src/escape.rs

Apply more suggestions. Add a test for non-utf8 chars for escape.

Slight refactor of escape.

Run cargo clippy --fix and persist all modifications to escape.rs

Apply rustfmt to command.rs and escape.rs

Lint over_session test

Update src/escape.rs

Update src/escape.rs

Update src/escape.rs

Apply more suggestions.

Rustfmt fix.

Fix a doctest for overssh.

Add a test for overssh that requires escaping the argument passed to the command.

Update overssh require-escaping-arguments test to contain a space.

Apply rustfmt to tests/openssh.rs