Skip to content

deploy CatalogSource in openshift-marketplace to allow reuse across namespaces#2119

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:oadp-devfrom
PrasadJoshi12:catsrc
Mar 18, 2026
Merged

deploy CatalogSource in openshift-marketplace to allow reuse across namespaces#2119
openshift-merge-bot[bot] merged 1 commit intoopenshift:oadp-devfrom
PrasadJoshi12:catsrc

Conversation

@PrasadJoshi12
Copy link
Contributor

@PrasadJoshi12 PrasadJoshi12 commented Mar 16, 2026

Why the changes were made

we want to re-use the same catsrc to deploy oadp operator in multiple namespaces for testing.

How to test the changes made

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: da2accf3-d3b4-44dc-b487-ccb1ebd4b1c5

📥 Commits

Reviewing files that changed from the base of the PR and between 7c8a3f1 and 862963e.

📒 Files selected for processing (1)
  • Makefile

Walkthrough

The change introduces a new CATALOG_SOURCE_NAMESPACE variable for OpenShift Marketplace CatalogSource operations and refactors the deploy-olm target by replacing OADP_TEST_NAMESPACE references with the new namespace for all CatalogSource-related actions, while adding new image and temporary directory variables.

Changes

Cohort / File(s) Summary
Makefile Namespace Refactoring
Makefile
Added public CATALOG_SOURCE_NAMESPACE variable (defaulting to openshift-marketplace) and replaced OADP_TEST_NAMESPACE with CATALOG_SOURCE_NAMESPACE across CatalogSource creation, readiness checks, deletion, and related queries. Expanded deploy-olm target with THIS_BUNDLE_IMAGE, THIS_CATALOG_IMAGE, and DEPLOY_TMP temporary directory variables.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can generate a title for your PR based on the changes.

Add @coderabbitai placeholder anywhere in the title of your PR and CodeRabbit will replace it with a title based on the changes in the PR. You can change the placeholder by changing the reviews.auto_title_placeholder setting.

@openshift-ci openshift-ci bot requested review from kaovilai and sseago March 16, 2026 12:41
@mpryc
Copy link
Contributor

mpryc commented Mar 16, 2026

/lgtm

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2026
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2026
@PrasadJoshi12
Copy link
Contributor Author

/retest

Copy link
Contributor

@weshayutin weshayutin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM :)
/LGTM

......InstallPlan install-8w24j found
Waiting for CSV to exist...
CSV oadp-operator.v99.0.0 found
Waiting for CSV to be ready...
clusterserviceversion.operators.coreos.com/oadp-operator.v99.0.0 condition met
Operator is ready!
NAME            PACKAGE         SOURCE                  CHANNEL
oadp-operator   oadp-operator   oadp-operator-catalog   dev
NAME                    DISPLAY         VERSION   RELEASE   REPLACES   PHASE
oadp-operator.v99.0.0   OADP Operator   99.0.0                         Succeeded
whayutin@fedora:~/OPENSHIFT/git/OADP/oadp-operator$ git branch
+ 2025-11-18-6lkt-wnY0i
* catsrc

@openshift-merge-bot openshift-merge-bot bot merged commit f08beb2 into openshift:oadp-dev Mar 18, 2026
18 of 19 checks passed
@openshift-ci
Copy link

openshift-ci bot commented Mar 18, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mpryc, PrasadJoshi12, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@PrasadJoshi12
Copy link
Contributor Author

/cherry-pick oadp-1.6

@openshift-cherrypick-robot
Copy link
Contributor

@PrasadJoshi12: new pull request created: #2123

Details

In response to this:

/cherry-pick oadp-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tareqalayan
Copy link
Contributor

Can we also cherry-pick for branch oadp-1.6 ?

@shubham-pampattiwar
Copy link
Member

Can we also cherry-pick for branch oadp-1.6 ?

#2123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants