deploy CatalogSource in openshift-marketplace to allow reuse across namespaces#2119
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe change introduces a new CATALOG_SOURCE_NAMESPACE variable for OpenShift Marketplace CatalogSource operations and refactors the deploy-olm target by replacing OADP_TEST_NAMESPACE references with the new namespace for all CatalogSource-related actions, while adding new image and temporary directory variables. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can generate a title for your PR based on the changes.Add |
|
/lgtm |
|
/retest |
weshayutin
left a comment
There was a problem hiding this comment.
WFM :)
/LGTM
......InstallPlan install-8w24j found
Waiting for CSV to exist...
CSV oadp-operator.v99.0.0 found
Waiting for CSV to be ready...
clusterserviceversion.operators.coreos.com/oadp-operator.v99.0.0 condition met
Operator is ready!
NAME PACKAGE SOURCE CHANNEL
oadp-operator oadp-operator oadp-operator-catalog dev
NAME DISPLAY VERSION RELEASE REPLACES PHASE
oadp-operator.v99.0.0 OADP Operator 99.0.0 Succeeded
whayutin@fedora:~/OPENSHIFT/git/OADP/oadp-operator$ git branch
+ 2025-11-18-6lkt-wnY0i
* catsrc
f08beb2
into
openshift:oadp-dev
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mpryc, PrasadJoshi12, weshayutin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick oadp-1.6 |
|
@PrasadJoshi12: new pull request created: #2123 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Can we also cherry-pick for branch oadp-1.6 ? |
|
Why the changes were made
we want to re-use the same catsrc to deploy oadp operator in multiple namespaces for testing.
How to test the changes made