ENH: Expose target_crs in georeference accessor#360
Open
syedhamidali wants to merge 1 commit intoopenradar:mainfrom
Open
ENH: Expose target_crs in georeference accessor#360syedhamidali wants to merge 1 commit intoopenradar:mainfrom
target_crs in georeference accessor#360syedhamidali wants to merge 1 commit intoopenradar:mainfrom
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #360 +/- ##
=======================================
Coverage 93.85% 93.85%
=======================================
Files 28 28
Lines 6165 6165
=======================================
Hits 5786 5786
Misses 379 379
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
history.mdDescription
Follow-up to #300: wires the
target_crsparameter through the.xradar.georeference()accessor on DataArray, Dataset, and DataTree, so users can reproject radar coordinates in a single accessor call instead of reaching forxd.georeference.get_x_y_z_tree(...).Example
Addresses the follow-up API request in #243 / #300 (comment by @kmuehlbauer).
Changes
xradar/accessors.py: forward target_crs through georeference() on all three accessors.
tests/test_accessors.py: two new tests covering target_crs=4326 for Dataset and DataTree, verifying geographic attrs and reprojected origin.