MNT: Improve Contributing Guide#354
Conversation
kmuehlbauer
left a comment
There was a problem hiding this comment.
I like it. Thanks @syedhamidali! Let's wait another day for others to chime in. But we can expand this anytime.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #354 +/- ##
=======================================
Coverage 93.85% 93.85%
=======================================
Files 28 28
Lines 6165 6165
=======================================
Hits 5786 5786
Misses 379 379
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks @syedhamidali for this PR. I'd like to take this opportunity to open a broader discussion that I think is timely for all of us. AI-Assisted ContributionsWe all know that LLMs are now part of our development workflows. This is great — code can move faster than ever. But it also creates a real challenge for us as maintainers: reviewing and understanding contributions that can now be hundreds or thousands of lines, generated in minutes. The asymmetry between writing code with AI and reviewing it is significant, and we need to address it head-on. The Icechunk team recently formalized an AI Usage Policy that I think captures this well. Their core principles:
This PR is a concrete example of how this plays out in practice — a 2,000+ line AI-generated contribution that prompted the Icechunk team to formalize their policy. I think we should adopt a similar policy for xradar. We are a small team, and our review capacity is limited. Clear expectations will help both contributors and maintainers. Proposed Process ImprovementsBeyond the AI policy, I'd like to propose two things:
What do you think about this? @kmuehlbauer @mgrover1 @syedhamidali @egouden |
|
@aladinor Yes, + 💯 for AI policy as suggested. This topic would warrant it's own issue. |
|
@syedhamidali do you think we can use the the |
|
@aladinor absolutely, it looks great. |
|
@syedhamidali @aladinor What's the plan to move on here? Should this be merged as-is or will the mentioned AI policy added here, too? |
|
@kmuehlbauer let me see if I can adapt the IA policy today along with #361 in a new PR |
|
Hello @aladinor @kmuehlbauer and folks! Figure to post here to discuss what we discussed @scollis @rcjackson @jrobrien91 plan on doing for Py-ART as well. I do like your points on the AI policy, funny enough we were discussing a similar policy for Py-ART utilizing, the xarray policy as a starting point. The only other points we might be adding is that for CI related PRs for actions or dependencies or if a person/agent is trying to add a dependency to the environment that AI is advised not to be used or maintainer only or an issue is opened to disuss the new dependency etc. The thought behind this is there have been malicious cases or PRs trying to add malicious dependencies, which can be a concern. And also if users, if they do use AI to possibly list what model and version. Were willing to discuss more if need be! But figure to share our thoughts as well. Cheers! |
|
Thanks @zssherman for the thoughtful additions. Both of your points made it into a new draft PR I just opened to continue this conversation with the wider community: #363. What's there:
It's opened as draft so we can iterate on the language before merge — feedback from you, @scollis, @rcjackson, and @jrobrien91 is very welcome, especially if Py-ART ends up with a similar policy and we can keep them aligned. Thanks @kmuehlbauer @syedhamidali @mgrover1 @egouden — please chime in on #363 when you have a moment. |
history.mdUpdates the contributing guide to clarify contributor, team-member, and maintainer roles, and adds a short pathway for getting more involved in xradar. See discussion in #341