Avoid "Window.getComputedStyle does not implement interface Element" exception in Firefox#1425
Open
ejn wants to merge 1 commit intoopenlayers:masterfrom
Open
Avoid "Window.getComputedStyle does not implement interface Element" exception in Firefox#1425ejn wants to merge 1 commit intoopenlayers:masterfrom
ejn wants to merge 1 commit intoopenlayers:masterfrom
Conversation
In Firefox an error "does not implement interface Element" was being raised when the MouseWheel event was outside the map, due to the traverse up the tree winding up at the document element. This error was caught in the try-catch block and so did not bubble up to the user, but trying to use Firebug and stop on all errors then it caused some irritation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Firefox an exception "Window.getComputedStyle does not implement interface Element" was being raised when the MouseWheel event was outside the map, due to the traverse up the tree winding up at the document object (which naturally doesn't implement the Element interface!).
This error was swallowed in the try-catch block and so did not bubble up to the user, but trying to use Firebug and stop on all errors then it becomes noticeable.
No changes required in the test-suite (which passes!).