Closed
Conversation
Member
There was a problem hiding this comment.
I think this isn't doing what you expect it to be doing.
I'd go with
if (layer instanceof OpenLayers.Layer.UTFGrid ||
layer instanceof OpenLayers.Layer.UTFGridWMS) {
// ...
}
Member
|
Hey @fdesj, would you be able to add tests and adress my other comments? I think that the new layer-class has a lot of duplicated code which you do not actually need. I have only shortly scanned the code so far, I wouldn't call this a full-blown review. |
fblackburn
pushed a commit
to fblackburn/openlayers
that referenced
this pull request
Apr 10, 2014
*Remove some code repetition and fix some error. *Modifications are based on the comment from the pull request openlayers#1076
mbarto
added a commit
to mbarto/openlayers
that referenced
this pull request
Jan 13, 2016
Member
|
Superseded by #1486. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a patch for a UTFGrid using a WMS service. This is in prediction for MapServer UTFGrid.