8317801: java/net/Socket/asyncClose/Race.java fails intermittently (aix)#4294
Open
shruacha1234 wants to merge 1 commit intoopenjdk:masterfrom
Open
8317801: java/net/Socket/asyncClose/Race.java fails intermittently (aix)#4294shruacha1234 wants to merge 1 commit intoopenjdk:masterfrom
shruacha1234 wants to merge 1 commit intoopenjdk:masterfrom
Conversation
Signed-off-by: Shruthi <Shruthi.Shruthi1@ibm.com>
|
👋 Welcome back sacharya! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request contains a backport of commit 8f121a17 from the openjdk/jdk repository.
OpenJDK bug : https://bugs.openjdk.org/browse/JDK-8317801
This fix resolves a race condition in socket close handling that led to intermittent failures in Race.java on AIX in JDK17u-dev
The original patch didn’t apply cleanly to the JDK17u-dev branch due to differences in the NIO dispatcher implementation:
UnixDispatcherintroduced in later JDK versions does not exist in JDK17.Virtual threadrelated logic in the original patch is not present in JDK17.To adapt the change for JDK17:
NativeDispatcher.preClosewas updated to accept the reader and writer thread IDs.FileDispatcherImpl.These changes preserve the functional intent of the upstream patch, ensuring that threads blocked in I/O operations are correctly signalled when a file descriptor is pre-closed.
Testing : local AIX build, java_io, java_nio, jdk_net
Additionally, executed java/net/Socket/asyncClose/Race.java 500 times to check for intermittent failures. No failures were observed.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4294/head:pull/4294$ git checkout pull/4294Update a local copy of the PR:
$ git checkout pull/4294$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4294/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4294View PR using the GUI difftool:
$ git pr show -t 4294Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4294.diff
Using Webrev
Link to Webrev Comment