8240908: RetransformClass does not know about MethodParameters attribute

[jpbempel]

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8240908 needs maintainer approval

Issue

• JDK-8240908: RetransformClass does not know about MethodParameters attribute (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4265/head:pull/4265
$ git checkout pull/4265

Update a local copy of the PR:
$ git checkout pull/4265
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4265/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4265

View PR using the GUI difftool:
$ git pr show -t 4265

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4265.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jpbempel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (ac6c0f65)

[openjdk]

⚠️ @jpbempel This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[GoeLin]

Hi @jpbempel
can you please do dependent pull request for the follow-up issues?
I ran your change through our testing and the new test fails.
Thanks.

[kriegaex]

@GoeLin, I am just an interested spectator here, I hope it is OK to ask some questions:

1. Where can I see the results of your failed tests to find out what exactly went wrong? The build checks here seem to indicate no errors.
2. Why a "dependent pull request", whatever that may mean to you? Is it not easier to just update this PR by either force-pushing an improved version or just committing fixes on top of it?

[jpbempel]

Hi @jpbempel can you please do dependent pull request for the follow-up issues? I ran your change through our testing and the new test fails. Thanks.

I ran locally tier1 and only this test is failing: java/util/Locale/PreserveTagCase.java
But it fails without my change on master.
Please provide more information on fail tests on your side

[GoeLin]

Hi @jpbempel
The JBS issue lists as related issuee JDK-8281243 Test java/lang/instrument/RetransformWithMethodParametersTest.java is failing
You need to backport that on top of this change, a so called "dependend pull request":
check out origin/pr/4265, make a new branch backport_8281243 on top, push that branch and compare to 4265 in the PR.