Skip to content

8342934: TYPE_USE annotations printed with error causing "," in toString output #4243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cushon wants to merge 2 commits into
base: pr/4242
Choose a base branch
from
Open

8342934: TYPE_USE annotations printed with error causing "," in toString output #4243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50bfedb
Backport ff165f9f0cf519144d7361b766bcce53d04c518e
cushon Jan 27, 2026
378913b
Merge branch 'JDK-8281238' into backport-JDK-8342934
cushon Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/jdk.compiler/share/classes/com/sun/tools/javac/code/Type.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@ protected void appendAnnotationsString(StringBuilder sb,
if (prefix) {
sb.append(" ");
}
sb.append(getAnnotationMirrors());
sb.append(getAnnotationMirrors().toString(" "));
sb.append(" ");
}
}
Expand Down
2 changes: 1 addition & 1 deletion ...gtools/tools/javac/processing/model/type/AnnotatedTypeToString/AnnotatedTypeToString.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

/*
* @test
* @bug 8284220
* @bug 8284220 8342934
* @summary Tests DeclaredType.toString with type annotations present, for example that '@A
* Map.Entry' is printed as 'java.util.@A Map.Entry' (and not '@A java.util.Map.Entry' or
* 'java.util.@A Entry').
Expand Down
8 changes: 6 additions & 2 deletions test/langtools/tools/javac/processing/model/type/AnnotatedTypeToString/Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@
@Target(ElementType.TYPE_USE)
@interface A {}

@Retention(RetentionPolicy.RUNTIME)
@Target(ElementType.TYPE_USE)
@interface B {}

public class Test {
static class StaticNested {
static class InnerMostStaticNested {}
Expand All @@ -41,8 +45,8 @@ class Inner {
class InnerMost {}
}

@ExpectedToString("p.Test.@p.A StaticNested")
@A StaticNested i;
@ExpectedToString("p.Test.@p.A @p.B StaticNested")
@A @B StaticNested i;

@ExpectedToString("p.Test.StaticNested.@p.A InnerMostStaticNested")
StaticNested.@A InnerMostStaticNested j;
Expand Down