8281238: TYPE_USE annotations not printed in correct position in toString output#4242
Open
cushon wants to merge 3 commits intoopenjdk:masterfrom
Open
8281238: TYPE_USE annotations not printed in correct position in toString output#4242cushon wants to merge 3 commits intoopenjdk:masterfrom
cushon wants to merge 3 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back cushon! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
Contributor
Author
|
/issue add JDK-8284220 |
|
@cushon |
Webrevs
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backport of JDK-8281238 fixes a bug in
TypeMirror#toStringoutput when printing type annotations.TypeMirror#toStringis specified to return a string that is "suitable for representing this type in source code". This fix causes type annotations on qualified names to be printed at the correct location, for examplejava.lang.@Annotation Stringinstead of@Annotation java.lang.String.There was a bug in the initial fix for JDK-8281238, follow-on fix JDK-8284220 is included in this backport.
Progress
Issues
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4242/head:pull/4242$ git checkout pull/4242Update a local copy of the PR:
$ git checkout pull/4242$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4242/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4242View PR using the GUI difftool:
$ git pr show -t 4242Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4242.diff
Using Webrev
Link to Webrev Comment