Skip to content

8371503: RETAIN_IMAGE_AFTER_TEST do not work for some tests#4215

Open
sendaoYan wants to merge 2 commits intoopenjdk:masterfrom
openjdk-bots:backport-sendaoYan-34f24131-master
Open

8371503: RETAIN_IMAGE_AFTER_TEST do not work for some tests#4215
sendaoYan wants to merge 2 commits intoopenjdk:masterfrom
openjdk-bots:backport-sendaoYan-34f24131-master

Conversation

@sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Dec 15, 2025

Hi all,

This pull request contains a backport of commit 34f24131 from the openjdk/jdk repository.

The commit being backported was authored by SendaoYan on 15 Dec 2025 and was reviewed by Leonid Mesnik and David Holmes.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8371503 needs maintainer approval

Issue

  • JDK-8371503: RETAIN_IMAGE_AFTER_TEST do not work for some tests (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4215/head:pull/4215
$ git checkout pull/4215

Update a local copy of the PR:
$ git checkout pull/4215
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4215/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4215

View PR using the GUI difftool:
$ git pr show -t 4215

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4215.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 15, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 15, 2025

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371503: RETAIN_IMAGE_AFTER_TEST do not work for some tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 1e113f4: 8298783: java/lang/ref/FinalizerHistogramTest.java failed with "RuntimeException: MyObject is not found in test output"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 34f241317ecd7473cfb6dcc2e6e5cf3a40299e2c 8371503: RETAIN_IMAGE_AFTER_TEST do not work for some tests Dec 15, 2025
@openjdk
Copy link

openjdk bot commented Dec 15, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Dec 15, 2025
@openjdk
Copy link

openjdk bot commented Dec 15, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 15, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 15, 2025

Webrevs

@sendaoYan
Copy link
Member Author

Change has been verified locally on linux-x64. This clean backport PR will make all the docker tests receive -Djdk.test.docker.retain.image property correctly.

Verify command:

j -Djdk.test.docker.image.name=jdk-build -Djdk.test.docker.image.version=11 -conc:20 $(git status -s | awk '{print $NF}' | sed "/ockerTestUtils.java/d" | xargs)

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 15, 2026

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

/touch

@openjdk
Copy link

openjdk bot commented Jan 15, 2026

@sendaoYan The pull request is being re-evaluated and the inactivity timeout has been reset.

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 12, 2026

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

/approval request Clean backport to fix bug which try to make all the docker tests receive -Djdk.test.docker.retain.image property correctly. Change has been verified locally on linux-x64. Test-fix only, no risk.

@openjdk
Copy link

openjdk bot commented Feb 13, 2026

@sendaoYan
8371503: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received and removed approval Requires approval; will be removed when approval is received labels Feb 13, 2026
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 13, 2026

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

/approval request Clean backport to fix bug which try to make all the docker tests receive -Djdk.test.docker.retain.image property correctly. Change has been verified locally on linux-x64. Test-fix only, no risk.

@openjdk
Copy link

openjdk bot commented Mar 16, 2026

@sendaoYan
8371503: The approval request was already up to date.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant