feat(shared, frontend, backend): organise shared exports dual format build#9215
Open
kevin9foong wants to merge 6 commits intodevelopfrom
Open
feat(shared, frontend, backend): organise shared exports dual format build#9215kevin9foong wants to merge 6 commits intodevelopfrom
kevin9foong wants to merge 6 commits intodevelopfrom
Conversation
25e77ab to
43bc9c6
Compare
43bc9c6 to
feccf69
Compare
137bbaf to
1fd6ab9
Compare
kevin9foong
commented
Mar 18, 2026
| - run: pnpm lint:frontend | ||
|
|
||
| backend_test: | ||
| needs: [changes, install, build] |
Contributor
Author
There was a problem hiding this comment.
rationale: backend test does not need to wait for build, saving ~2mins in ci time
21780de to
623ed56
Compare
623ed56 to
c3c1620
Compare
kevin9foong
commented
Mar 18, 2026
| env: | ||
| NODE_OPTIONS: '--max-old-space-size=4096' | ||
| AWS_SDK_JS_SUPPRESS_MAINTENANCE_MODE_MESSAGE: 1 | ||
| - name: Upload build files |
Contributor
Author
There was a problem hiding this comment.
note: these build files are not being used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Enable dual-format building for shared package.
Requirements:
Closes [insert issue #]
Solution
Suggesting the following structure:
To support the barrel for constants, we need to fix the name conflict with
typesinconstants/fields/myinfoandconstants/fields/basic, hence they have been renamed to avoid conflict.Use tsdown to automate esm, cjs build and export resolution.
ci.yml dependency updates should theoretically speed up our ci.yml job completion by 1-2mins per run.
Breaking Changes
No - this PR is backwards compatible