Conversation
|
No major YANG version changes in commit e4534cb |
earies
left a comment
earies
left a comment
There was a problem hiding this comment.
Some instance data examples might also assist here. While a policy reference is meant to act as a filter that needs to evaluate to true, are all combinations of match/actions permitted here or will this focus on a subset in policy modeling (and if policy modeling expands over time)
|
Also in case its not obvious - if we think holistically, this could apply to many scenarios across subtrees where filtering is desirable on either policy matches or beyond - has there been consideration to other domains and if so, could this lead down a path of potential common filter block reuse |
|
/gcbrun |
Added some info the description, and more details are in the test plan. |
In this case, we did do some internal discussion on whether or not it made sense to do the filtering at subscribe time, but in general it is a very hard problem-- in this case, we want to do the filtering at config time to give the box the ability to do some optimizations in matching against the policy-- otherwise, you need some sort of internal mechanism where the gnmi agents will need to have nontrivial interaction with other daemons on the device to learn how to do filtering. -- Also subscription time filtering would be less performant. So, this change is purposely scoped to be very "narrow." |
dplore
left a comment
dplore
left a comment
There was a problem hiding this comment.
Reviewed in March 17, 2026 OC Operators meeting without objection. Setting to last call for March 31, 2026
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
| "Reference to a routing policy that is used to filter the | ||
| IPv6 prefixes that are present in the FIB. Only prefixes | ||
| that are accepted by the referenced policy are streamed. | ||
| The policy may, for example, use an explicit prefix set to | ||
| match prefixes, or match prefixes that are more specific than | ||
| a given prefix."; |
There was a problem hiding this comment.
| "Reference to a routing policy that is used to filter the | |
| IPv6 prefixes that are present in the FIB. Only prefixes | |
| that are accepted by the referenced policy are streamed. | |
| The policy may, for example, use an explicit prefix set to | |
| match prefixes, or match prefixes that are more specific than | |
| a given prefix."; | |
| "Reference to a routing policy that is used to filter the | |
| IPv6 prefixes that are streamed from the FIB. This does | |
| not affect which prefixes are installed in the FIB. | |
| The policy may, for example, use an explicit prefix set to | |
| match prefixes, or match prefixes that are more specific than | |
| a given prefix."; |
| } | ||
| description | ||
| "Reference to a routing policy that is used to filter the | ||
| IPv4 prefixes that are in the FIB. Only prefixes |
There was a problem hiding this comment.
Same comment as above to clarify this only affects the streaming of prefixes.
5 participants
Change Scope
aftstree based on a named routing policy.aftsas arwcontainer rather than arocontainer since we're adding a configuration leaf.Platform Implementations
This request is being made without any existing implementations that I know of. We will be requesting this from the vendors. (and so we will need at least 2 approvals from different vendors)
Tree View
Notably,
Is the part being added (and the rest are part of the diff because there's an extra
|at the start of the line).Feature Profile Testing
Some of the functionality / expected behavior can be found in this feature profile PR.