[Juniper] Only set the legacy gRPC services config if the specific node label isn't set.#647
Merged
NehaManjunath merged 5 commits intoopenconfig:mainfrom Sep 19, 2025
Merged
Conversation
…de label isn't set. These config lines are now not required in D47 and will cause future config commits to fail if combined with the newer gRPC services configuration.
Contributor
|
/gcbrun |
Contributor
Author
|
@NehaManjunath The KNE presubmit failed but it's hard to tell if it's related to my change. Could you run it again? |
Contributor
|
/gcbrun |
Contributor
Author
|
Hi folks, could I get a review of this PR? Also need some help to re-run the presubmit after pushing 107d189. |
Contributor
|
/gcbrun |
1 similar comment
Contributor
|
/gcbrun |
NehaManjunath
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These config lines are now not required in D47 and will cause future config commits to fail if combined with the newer gRPC services configuration.
From Juniper's D47 release notes:
NGINX-based server implementation allows for hosting GRPC services on ports specified in the system configuration. Configuration model for this feature is mutually exclusive from the existing GRPC server configuration model. The new standards-based server implementation brings in performance enhancements for scaling gRPC sessions and has built-in support for the gNSI security suite. Support for using PKID-based certificate intake as well hot-reloading of TLS certificates is already built-in to the solution and does not need to be explicitly configured.This configuration should be present in the bootstrap configuration, and the “set system services extension-service request-response grpc” hierarchy must NOT be present while this is present, otherwise the system will fail to apply the configuration since the two models are mutually exclusive.KNE topologies will be able to disable this legacy gRPC config by using this label.
Also incorporated a change from #622 that improved retry behavior on config pushes.