Skip to content

skip_neutral_temps only if SMB's somehow disabled #1452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mountrcg wants to merge 2 commits into
base: dev
Choose a base branch
from
+6 −2
Open

skip_neutral_temps only if SMB's somehow disabled #1452

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
050d4e5
skip_NetralTemps only if SMB's somehow disabled
mountrcg Jun 26, 2023
a823cf4
log message for not skipping neutral temps while SMB's are possible
mountrcg Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/determine-basal/determine-basal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -922,8 +922,8 @@ var maxDelta_bg_threshold;

// if not in LGS mode, cancel temps before the top of the hour to reduce beeping/vibration
// console.error(profile.skip_neutral_temps, rT.deliverAt.getMinutes());
if ( profile.skip_neutral_temps && rT.deliverAt.getMinutes() >= 55 ) {
rT.reason += "; Canceling temp at " + rT.deliverAt.getMinutes() + "m past the hour. ";
if ( profile.skip_neutral_temps && !enableSMB && rT.deliverAt.getMinutes() >= 55 ) {
Copy link
Copy Markdown
Contributor

@scottleibrand scottleibrand Jun 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to print some sort of “ignoring skip_neutral_temps because SMB is enabled” message if enableSMB?

Copy link
Copy Markdown
Contributor Author

@mountrcg mountrcg Jun 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done that, but only for the log, no rT.reason output - thinking too much clutter

2023-06-27 07:56:17.653895+0200 DEV: JavaScript log: maxDelta threshold for BG-Jump to allow SMB's set to: 30%
2023-06-27 07:56:17.654444+0200 DEV: JavaScript log: BG projected to remain above 100 for 240minutes
2023-06-27 07:56:17.654994+0200 DEV: JavaScript log: naive_eventualBG: 120, bgUndershoot: -50, zeroTempDuration: 240, zeroTempEffect: 351, carbsReq: -94
2023-06-27 07:56:17.655532+0200 DEV: JavaScript log: 4min before turn of the hour, but SMB's are enabled - no skipping neutral temps
2023-06-27 07:56:17.656076+0200 DEV: JavaScript log: SMB max range extended from default by factor 3
2023-06-27 07:56:17.656608+0200 DEV: JavaScript log: profile.maxSMBBasalMinutes:,120,profile.current_basal:,2.05
2023-06-27 07:56:17.657135+0200 DEV: JavaScript log: SMB Delivery Ratio increased from default 0.5 to 0.68
2023-06-27 07:56:17.657669+0200 DEV: JavaScript log: naive_eventualBG 120, 0m 0U/h temp needed; last bolus 1139.9m ago; maxBolus: 12.3

rT.reason += "; Canceling temp at " + (60 - rT.deliverAt.getMinutes()) + "min before turn of the hour to avoid beeping of MDT. SMB disabled anyways.";
return tempBasalFunctions.setTempBasal(0, 0, profile, rT, currenttemp);
}

Expand Down