Replace OnceLock with LazyLock#256
Merged
brotskydotcom merged 2 commits intoopen-source-cooperative:masterfrom Apr 23, 2025
russellbanks:lazylock
Merged
Replace OnceLock with LazyLock#256brotskydotcom merged 2 commits intoopen-source-cooperative:masterfrom russellbanks:lazylock
OnceLock with LazyLock#256brotskydotcom merged 2 commits intoopen-source-cooperative:masterfrom
russellbanks:lazylock
Conversation
brotskydotcom
approved these changes
Apr 23, 2025
Collaborator
brotskydotcom
left a comment
There was a problem hiding this comment.
Looks great, thanks a lot!
54a423f
into
open-source-cooperative:master
11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LazyLockis simpler thanOnceLockand the docs suggest its use over OnceLock in simple cases where different initializers based on the caller are not required:OnceCell was used in #160 (and therefore #179) as it became stable in v1.70 whilst LazyLock became stable in v1.80. With the MSRV bump of keyring v4 to v1.85, this is no longer a consideration.