Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -916,23 +916,10 @@ test.describe('Glossary Advanced Operations', () => {

await waitForAllLoadersToDisappear(page);

// Clear all related terms

await page
.getByTestId('tag-selector')
.locator('#tagsForm_tags')
.press('Backspace');
await page
.getByTestId('tag-selector')
.locator('#tagsForm_tags')
.press('Backspace');
await page
.getByTestId('tag-selector')
.locator('#tagsForm_tags')
.press('Backspace');
await page.locator('[data-testid^="remove-row-"]').first().click();

const validateRes = page.waitForResponse('/api/v1/glossaryTerms/*');
await page.getByTestId('saveAssociatedTag').click();
await page.getByTestId('save-related-terms').click();
await validateRes;

// Verify related term is removed
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -187,12 +187,10 @@ test.describe('Glossary Term Details Operations', () => {
.getByTestId('edit-button')
.click();

// Remove the related term by clicking the close icon on the tag
// Use a more robust selector that doesn't rely on FQN in attribute
await page.locator('.ant-tag-close-icon').first().click();
await page.locator('[data-testid^="remove-row-"]').first().click();

const saveRes = page.waitForResponse('/api/v1/glossaryTerms/*');
await page.getByTestId('saveAssociatedTag').click();
await page.getByTestId('save-related-terms').click();
await saveRes;

// Verify related term is removed
Expand Down Expand Up @@ -241,11 +239,10 @@ test.describe('Glossary Term Details Operations', () => {
.getByTestId('edit-button')
.click();

// Use a more robust selector
await page.locator('.ant-tag-close-icon').first().click();
await page.locator('[data-testid^="remove-row-"]').first().click();

const saveRes = page.waitForResponse('/api/v1/glossaryTerms/*');
await page.getByTestId('saveAssociatedTag').click();
await page.getByTestId('save-related-terms').click();
await saveRes;
} finally {
await glossaryTerm1.delete(apiContext);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1183,20 +1183,24 @@ export const addRelatedTerms = async (
relatedTerms: GlossaryTerm[]
) => {
await page.getByTestId('related-term-add-button').click();

const autocompleteInput = page
.locator('[data-testid^="term-autocomplete-"]')
.first()
.locator('input');

for (const term of relatedTerms) {
const entityName = get(term, 'responseData.name');
const entityFqn = get(term, 'responseData.fullyQualifiedName');
await page.locator('#tagsForm_tags').fill(entityName);
await page.getByTestId(`tag-${entityFqn}`).click();
await autocompleteInput.fill(entityName);
await page.getByRole('option', { name: entityName }).click();
}

const saveRes = page.waitForResponse('/api/v1/glossaryTerms/*');
await page.getByTestId('saveAssociatedTag').click();
await page.getByTestId('save-related-terms').click();
await saveRes;

for (const term of relatedTerms) {
const entityName = get(term, 'responseData.displayName');

await expect(page.getByTestId(entityName)).toBeVisible();
}
};
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading