feat: Add data dimensions, health, incident metrics, and test case status translations in multiple languages#26765
feat: Add data dimensions, health, incident metrics, and test case status translations in multiple languages#26765ShaileshParmar11 wants to merge 10 commits intomainfrom
Conversation
…atus translations in multiple languages - Updated Spanish, French, Galician, Hebrew, Japanese, Korean, Marathi, Dutch, Persian, Brazilian Portuguese, European Portuguese, Russian, Thai, Turkish, Simplified Chinese, and Traditional Chinese language files to include new keys for data dimensions, data health, incident metrics, and test case status. - Enhanced the Data Quality dashboard by integrating a new dashboard component and updating the sidebar to include a summary tab. - Modified Data Quality utility functions to support new test case status filtering and data transformation for improved reporting. - Introduced new styles for the dashboard and updated existing variables for better visual representation.
github-actions
bot
added
safe to test
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
openmetadata-ui/src/main/resources/ui/src/locale/languages/pr-pr.json
Outdated
Show resolved
Hide resolved
openmetadata-ui/src/main/resources/ui/src/locale/languages/es-es.json
Outdated
Show resolved
Hide resolved
openmetadata-ui/src/main/resources/ui/src/constants/DataQuality.constants.ts
Outdated
Show resolved
Hide resolved
…aQualityDashboard component
...ources/ui/src/components/DataQuality/DataQualityDashboard/DataQualityDashboard.component.tsx
Show resolved
Hide resolved
… including DataQualityDashboard integration
openmetadata-ui/src/main/resources/ui/src/pages/TagPage/tag-page.less
Outdated
Show resolved
Hide resolved
- Updated Russian, Thai, Turkish, Simplified Chinese, and Traditional Chinese language files to include new keys for data dimensions, data health, incident metrics, and test case status. - Added sub-header descriptions for data dimensions, data health, and incident metrics in respective language files. - Refactored imports in DataQualityClassBase, TagPage, DomainClassBase, and GlossaryTermClassBase to maintain consistent import order and structure. - Improved test cases in DomainClassBase, GlossaryTermClassBase, and TagClassBase for better readability and maintainability. - Removed unnecessary lines in TagClassBase.test.ts and TagsUtils.tsx to clean up the code.
… improved styling
…efine search query logic in DataQualityDashboard
There was a problem hiding this comment.
Pull request overview
This PR expands the Data Quality experience by adding a new “Summary/Dashboard” view and surfacing “Data Observability” tabs on governance entities (Tags, Glossary Terms, Domains), alongside broad i18n updates for the new dashboard content.
Changes:
- Adds a Data Quality dashboard “Summary” tab and left-sidebar entry, and makes it the default Data Quality landing tab.
- Introduces a reusable
DataQualityDashboardcomponent plus multiple new chart widgets (pie/area/status cards) and supporting utilities/constants/styles. - Updates many locale JSONs with new keys for data dimensions, data health, incident metrics, and test case status.
Reviewed changes
Copilot reviewed 61 out of 61 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| openmetadata-ui/src/main/resources/ui/src/utils/TagClassBase.ts | Adds DATA_OBSERVABILITY tab ID to tag detail tab set. |
| openmetadata-ui/src/main/resources/ui/src/utils/TagClassBase.test.ts | Updates expectations for the new tab and mocks i18n util. |
| openmetadata-ui/src/main/resources/ui/src/utils/Glossary/GlossaryTermClassBase.ts | Appends a Data Observability tab (DataQualityDashboard) to glossary term detail view. |
| openmetadata-ui/src/main/resources/ui/src/utils/Glossary/GlossaryTermClassBase.test.ts | Adds tests for the new tab behavior and props passed to the dashboard. |
| openmetadata-ui/src/main/resources/ui/src/utils/Domain/DomainClassBase.ts | Appends a Data Observability tab (DataQualityDashboard) to domain detail view. |
| openmetadata-ui/src/main/resources/ui/src/utils/Domain/DomainClassBase.test.ts | Adds tests validating the new domain tab behavior and filters. |
| openmetadata-ui/src/main/resources/ui/src/utils/DataQuality/DataQualityUtils.tsx | Adds helpers for dashboard navigation and status-by-dimension transformation and pie labels. |
| openmetadata-ui/src/main/resources/ui/src/styles/variables.less | Introduces @green-100 used by new widget styles. |
| openmetadata-ui/src/main/resources/ui/src/pages/TagPage/tag-page.less | Adds styling to size the new DQ tab pane. |
| openmetadata-ui/src/main/resources/ui/src/pages/TagPage/TagPage.tsx | Adds Data Observability tab to Tag page and aligns tab keys with EntityTabs. |
| openmetadata-ui/src/main/resources/ui/src/pages/DataQuality/DataQualityClassBase.ts | Adds “Summary” sidebar entry/tab and makes it the default. |
| openmetadata-ui/src/main/resources/ui/src/constants/DataQuality.constants.ts | Adds dashboard header metadata, dimension defaults, and DQ filter key constants. |
| openmetadata-ui/src/main/resources/ui/src/components/DataQuality/DataQualityDashboard/DataQualityDashboard.component.tsx | New dashboard view with filter bar, cards, and chart grid. |
| openmetadata-ui/src/main/resources/ui/src/components/DataQuality/DataQualityDashboard/DataQualityDashboard.interface.ts | New dashboard filter type(s). |
| openmetadata-ui/src/main/resources/ui/src/components/DataQuality/DataQualityDashboard/data-quality-dashboard.style.less | New styles for dashboard and governance embedding layout. |
| openmetadata-ui/src/main/resources/ui/src/components/DataQuality/DataQuality.interface.ts | Extends widget prop contracts to support new dashboard widgets. |
| openmetadata-ui/src/main/resources/ui/src/components/DataQuality/ChartWidgets/ChartWidgets.constants.ts | Adds shared pie segment orders for consistent click→status mapping. |
| openmetadata-ui/src/main/resources/ui/src/components/DataQuality/ChartWidgets/chart-widgets.less | Adds shared styling helpers for chart widgets. |
| openmetadata-ui/src/main/resources/ui/src/components/DataQuality/ChartWidgets/** | Adds multiple new chart/widget components and corresponding unit tests. |
| openmetadata-ui/src/main/resources/ui/src/locale/languages/*.json | Adds new translation keys across many supported locales. |
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| const childProps = (dqTab?.children as any).props; | ||
|
|
There was a problem hiding this comment.
Avoid using any for dqTab?.children in tests. This repo has a zero-tolerance rule for any in TS; instead, narrow children to a ReactElement and read props via a typed cast (e.g., React.ReactElement<{ isGovernanceView: boolean }>), or use a helper to extract props safely.
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| const childProps = (dqTab?.children as any).props; | ||
|
|
There was a problem hiding this comment.
Avoid using any for dqTab?.children in tests. Please narrow to a typed ReactElement (or add a small typed helper) so the test can access initialFilters without disabling @typescript-eslint/no-explicit-any.
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| const childProps = (dqTab?.children as any).props; | ||
|
|
There was a problem hiding this comment.
Avoid using any for dqTab?.children in tests. Please replace the any cast with a typed ReactElement cast or a type guard so we keep strict type-safety and don't need the eslint disable.
❌ Lint Check Failed — ESLint + Prettier + Organise Imports (src)The following files have style issues that need to be fixed: Fix locally (fast — changed files only): cd openmetadata-ui/src/main/resources/ui
yarn ui-checkstyle:changedOr to fix all files: |
Code Review 👍 Approved with suggestions 5 resolved / 6 findingsAdds multilingual translations for data dimensions, health, incident metrics, and test case status across the DataQualityDashboard and related UI components. Resolved issues with double scrollbars, Persian translation duplication, and stale timestamp constants; consider completing the TagTabs → EntityTabs migration in TagPage.tsx to maintain consistency. 💡 Quality: Incomplete TagTabs → EntityTabs migration in TagPage.tsx📄 openmetadata-ui/src/main/resources/ui/src/pages/TagPage/TagPage.tsx:118 📄 openmetadata-ui/src/main/resources/ui/src/pages/TagPage/TagPage.tsx:402-403 The diff migrates several
While the string values happen to be identical between both enums so this won't cause a runtime bug, mixing two enum types for the same variable reduces type safety and creates maintenance confusion. The Suggested fix✅ 5 resolved✅ Edge Case: Fixed height + overflow-y on all tab panes may cause double scrollbars
✅ Quality: Persian (pr-pr.json) translations are copy-pasted Arabic
✅ Quality: Several languages leave
|
| Auto-apply | Compact |
|
|
Was this helpful? React with 👍 / 👎 | Gitar
Jest test CoverageUI tests summary
|
|
🟡 Playwright Results — all passed (21 flaky)✅ 3395 passed · ❌ 0 failed · 🟡 21 flaky · ⏭️ 216 skipped
🟡 21 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
Describe your changes:
Fixes
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>