Skip to content

Remove unused GLUE credentials for playwright#26764

Open
tutte wants to merge 1 commit intomainfrom
chore/unused-secrets
Open

Remove unused GLUE credentials for playwright#26764
tutte wants to merge 1 commit intomainfrom
chore/unused-secrets

Conversation

@tutte
Copy link
Copy Markdown
Contributor

@tutte tutte commented Mar 25, 2026

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copilot AI review requested due to automatic review settings March 25, 2026 10:52
@github-actions github-actions bot added devops safe to test Add this label to run secure Github workflows on PRs labels Mar 25, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes unused AWS Glue-related Playwright environment variables from GitHub Actions E2E workflows, reducing secret surface area and workflow configuration noise.

Changes:

  • Removed PLAYWRIGHT_GLUE_* env vars from MySQL and PostgreSQL Playwright E2E workflows (including nightly variants).
  • Eliminated references to TEST_GLUE_* secrets from these workflows.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
.github/workflows/postgresql-nightly-e2e.yml Removes unused PLAYWRIGHT_GLUE_* env vars from the nightly Postgres E2E job.
.github/workflows/playwright-postgresql-e2e.yml Removes unused PLAYWRIGHT_GLUE_* env vars from the on-demand Postgres E2E job.
.github/workflows/playwright-mysql-e2e.yml Removes unused PLAYWRIGHT_GLUE_* env vars from the on-demand MySQL E2E job.
.github/workflows/mysql-nightly-e2e.yml Removes unused PLAYWRIGHT_GLUE_* env vars from the nightly MySQL E2E job.

@gitar-bot
Copy link
Copy Markdown

gitar-bot bot commented Mar 25, 2026

Code Review ✅ Approved

Removes unused GLUE credentials for playwright to reduce security surface area. No issues found.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants