Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes unused AWS Glue-related Playwright environment variables from GitHub Actions E2E workflows, reducing secret surface area and workflow configuration noise.
Changes:
- Removed
PLAYWRIGHT_GLUE_*env vars from MySQL and PostgreSQL Playwright E2E workflows (including nightly variants). - Eliminated references to
TEST_GLUE_*secrets from these workflows.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/postgresql-nightly-e2e.yml | Removes unused PLAYWRIGHT_GLUE_* env vars from the nightly Postgres E2E job. |
| .github/workflows/playwright-postgresql-e2e.yml | Removes unused PLAYWRIGHT_GLUE_* env vars from the on-demand Postgres E2E job. |
| .github/workflows/playwright-mysql-e2e.yml | Removes unused PLAYWRIGHT_GLUE_* env vars from the on-demand MySQL E2E job. |
| .github/workflows/mysql-nightly-e2e.yml | Removes unused PLAYWRIGHT_GLUE_* env vars from the nightly MySQL E2E job. |
Code Review ✅ ApprovedRemoves unused GLUE credentials for playwright to reduce security surface area. No issues found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>