Conversation
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
openmetadata-service/src/main/java/org/openmetadata/service/util/EntityUtil.java
Show resolved
Hide resolved
openmetadata-service/src/main/java/org/openmetadata/service/util/EntityUtil.java
Show resolved
Hide resolved
Code Review ✅ Approved 2 resolved / 2 findingsAdds "messageSchema" prefix support to the topic field with corresponding API endpoint and unit test updates, resolving missing prefix bugs in schema field handling. ✅ 2 resolved✅ Bug: Tests not updated for new "messageSchema" prefix
✅ Bug: APIEndpoint's getSchemaField likely has the same missing prefix bug
OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
OpenMetadata Service New-Code Coverage✅ PASS. Required changed-line coverage:
Only changed executable lines under |
|
🔴 Playwright Results — 1 failure(s), 25 flaky✅ 3406 passed · ❌ 1 failed · 🟡 25 flaky · ⏭️ 208 skipped
Genuine Failures (failed on all attempts)❌
|
|
Closing this PR as this fix requires running migrations across the db |
|
Possibly right Quick fix: #26735 |



This pull request updates the logic for generating schema field names for topics to include the
messageSchemaprefix, improving clarity and consistency in fully qualified names.Schema field naming improvements:
EntityUtil.getSchemaField(Topic, Field, String)to prepend"messageSchema"to the schema field's fully qualified name, changing the format from"schemaFields".fieldName.fieldNameto"messageSchema"."schemaFields".fieldName.fieldName. This clarifies that the schema fields belong to the message schema context.Summary by Gitar
getSchemaField()method forTopicto includemessageSchemaprefix in FQN path constructionThis will update automatically on new commits.