Add Bool.toString() by turbolent · Pull Request #4477 · onflow/cadence

turbolent · 2026-04-20T20:06:54Z

Description

Add toString() function to Bool.

Also, avoid an unnecessary diagnostic when a string template expression is an invalid type (upstream error, e.g. undeclared variable).

Targeted PR against master branch
Linked to Github issue with discussion and accepted design OR link to spec that describes this work
Code follows the standards mentioned here
Updated relevant documentation
Re-reviewed Files changed in the Github PR explorer
Added appropriate labels

github-actions · 2026-04-20T20:07:05Z

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

github-actions · 2026-04-20T20:15:03Z

Benchstat comparison

Base branch: onflow:master
Base commit: bc9c8c2

Results

	old.txt	new.txt
	time/op		delta
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ByteArrayTransfer-4	1.34µs ± 0%	1.29µs ± 0%	~	(p=1.000 n=1+1)
ByteArrayValueToByteSlice-4	80.5ns ± 0%	87.4ns ± 0%	~	(p=1.000 n=1+1)
ByteSliceToByteArrayValue-4	1.14µs ± 0%	1.06µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/compiler goos:linux goarch:amd64
CompileFungibleTokenTransferTransaction-4	135µs ± 0%	129µs ± 0%	~	(p=1.000 n=1+1)
CompileTime-4	41.3µs ± 0%	40.5µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ContractFunctionInvocation-4	416µs ± 0%	413µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
ContractImport-4	249µs ± 0%	233µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
EMVAddressTransfer-4	3.85µs ± 0%	3.70µs ± 0%	~	(p=1.000 n=1+1)
Emit-4	4.75ms ± 0%	4.78ms ± 0%	~	(p=1.000 n=1+1)
EnumTransfer-4	1.53µs ± 0%	1.46µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ExportType/composite_type-4	270ns ± 0%	272ns ± 0%	~	(p=1.000 n=1+1)
ExportType/simple_type-4	78.0ns ± 0%	77.9ns ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
FTTransfer-4	169µs ± 0%	170µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/sema goos:linux goarch:amd64
FlowTokenContract-4	625µs ± 0%	635µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ImperativeFib-4	23.9µs ± 0%	22.6µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
ImperativeFib-4	25.7µs ± 0%	25.9µs ± 0%	~	(p=1.000 n=1+1)
ImperativeFibNewCompilerNewVM-4	50.5µs ± 0%	49.7µs ± 0%	~	(p=1.000 n=1+1)
ImperativeFibNewVM-4	28.9µs ± 0%	28.9µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
InterpretRecursionFib-4	2.43ms ± 0%	2.39ms ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
InterpreterFTTransfer-4	137µs ± 0%	138µs ± 0%	~	(p=1.000 n=1+1)
InterpreterImperativeFib-4	24.2µs ± 0%	23.1µs ± 0%	~	(p=1.000 n=1+1)
InterpreterNewStruct-4	70.5µs ± 0%	67.0µs ± 0%	~	(p=1.000 n=1+1)
MethodCall/concrete_type_method_call-4	46.7µs ± 0%	46.5µs ± 0%	~	(p=1.000 n=1+1)
MethodCall/interface_method_call-4	66.8µs ± 0%	65.5µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
NewInterpreter/new_interpreter-4	874ns ± 0%	864ns ± 0%	~	(p=1.000 n=1+1)
NewInterpreter/new_sub-interpreter-4	358ns ± 0%	326ns ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
NewResource-4	108µs ± 0%	103µs ± 0%	~	(p=1.000 n=1+1)
NewStruct-4	48.2µs ± 0%	47.2µs ± 0%	~	(p=1.000 n=1+1)
NewStructRaw-4	3.39µs ± 0%	3.47µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/sema goos:linux goarch:amd64
QualifiedIdentifierCreation/One_level-4	2.50ns ± 0%	1.89ns ± 0%	~	(p=1.000 n=1+1)
QualifiedIdentifierCreation/Three_levels-4	84.6ns ± 0%	87.0ns ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
RecursionFib-4	1.64ms ± 0%	1.61ms ± 0%	~	(p=1.000 n=1+1)
RuntimeFungibleTokenTransfer-4	835µs ± 0%	818µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
RuntimeFungibleTokenTransferInterpreter-4	684µs ± 0%	650µs ± 0%	~	(p=1.000 n=1+1)
RuntimeFungibleTokenTransferVM-4	754µs ± 0%	751µs ± 0%	~	(p=1.000 n=1+1)
RuntimeResourceDictionaryValues-4	2.95ms ± 0%	2.90ms ± 0%	~	(p=1.000 n=1+1)
RuntimeResourceTracking-4	10.5ms ± 0%	10.3ms ± 0%	~	(p=1.000 n=1+1)
RuntimeScriptNoop-4	16.1µs ± 0%	14.9µs ± 0%	~	(p=1.000 n=1+1)
RuntimeVMInvokeContractImperativeFib-4	43.0µs ± 0%	44.0µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/sema goos:linux goarch:amd64
SuperTypeInference/arrays-4	233ns ± 0%	232ns ± 0%	~	(p=1.000 n=1+1)
SuperTypeInference/composites-4	90.4ns ± 0%	94.1ns ± 0%	~	(p=1.000 n=1+1)
SuperTypeInference/integers-4	317ns ± 0%	319ns ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ValueIsSubtypeOfSemaType-4	61.1ns ± 0%	62.0ns ± 0%	~	(p=1.000 n=1+1)

	alloc/op		delta
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ByteArrayTransfer-4	1.03kB ± 0%	1.07kB ± 0%	~	(p=1.000 n=1+1)
ByteArrayValueToByteSlice-4	32.0B ± 0%	32.0B ± 0%	~	(all equal)
ByteSliceToByteArrayValue-4	876B ± 0%	859B ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/compiler goos:linux goarch:amd64
CompileFungibleTokenTransferTransaction-4	82.9kB ± 0%	82.9kB ± 0%	~	(all equal)
CompileTime-4	16.9kB ± 0%	16.9kB ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ContractFunctionInvocation-4	144kB ± 0%	144kB ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
ContractImport-4	75.5kB ± 0%	75.4kB ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
EMVAddressTransfer-4	2.46kB ± 0%	2.45kB ± 0%	~	(p=1.000 n=1+1)
Emit-4	1.50MB ± 0%	1.51MB ± 0%	~	(p=1.000 n=1+1)
EnumTransfer-4	835B ± 0%	832B ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ExportType/composite_type-4	120B ± 0%	120B ± 0%	~	(all equal)
ExportType/simple_type-4	0.00B	0.00B	~	(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
FTTransfer-4	43.6kB ± 0%	43.6kB ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/sema goos:linux goarch:amd64
FlowTokenContract-4	226kB ± 0%	226kB ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ImperativeFib-4	8.30kB ± 0%	8.30kB ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
ImperativeFib-4	5.41kB ± 0%	5.41kB ± 0%	~	(all equal)
ImperativeFibNewCompilerNewVM-4	25.8kB ± 0%	25.8kB ± 0%	~	(all equal)
ImperativeFibNewVM-4	8.10kB ± 0%	8.10kB ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
InterpretRecursionFib-4	1.19MB ± 0%	1.19MB ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
InterpreterFTTransfer-4	42.0kB ± 0%	42.0kB ± 0%	~	(p=1.000 n=1+1)
InterpreterImperativeFib-4	8.29kB ± 0%	8.29kB ± 0%	~	(all equal)
InterpreterNewStruct-4	24.9kB ± 0%	24.8kB ± 0%	~	(p=1.000 n=1+1)
MethodCall/concrete_type_method_call-4	10.2kB ± 0%	10.2kB ± 0%	~	(p=1.000 n=1+1)
MethodCall/interface_method_call-4	17.1kB ± 0%	17.1kB ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
NewInterpreter/new_interpreter-4	976B ± 0%	976B ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-4	232B ± 0%	232B ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
NewResource-4	44.0kB ± 0%	44.0kB ± 0%	~	(p=1.000 n=1+1)
NewStruct-4	13.6kB ± 0%	13.6kB ± 0%	~	(p=1.000 n=1+1)
NewStructRaw-4	1.71kB ± 0%	1.75kB ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/sema goos:linux goarch:amd64
QualifiedIdentifierCreation/One_level-4	0.00B	0.00B	~	(all equal)
QualifiedIdentifierCreation/Three_levels-4	64.0B ± 0%	64.0B ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
RecursionFib-4	283kB ± 0%	283kB ± 0%	~	(p=1.000 n=1+1)
RuntimeFungibleTokenTransfer-4	241kB ± 0%	241kB ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
RuntimeFungibleTokenTransferInterpreter-4	165kB ± 0%	165kB ± 0%	~	(p=1.000 n=1+1)
RuntimeFungibleTokenTransferVM-4	188kB ± 0%	188kB ± 0%	~	(p=1.000 n=1+1)
RuntimeResourceDictionaryValues-4	1.76MB ± 0%	1.76MB ± 0%	~	(p=1.000 n=1+1)
RuntimeResourceTracking-4	6.98MB ± 0%	6.99MB ± 0%	~	(p=1.000 n=1+1)
RuntimeScriptNoop-4	8.09kB ± 0%	8.09kB ± 0%	~	(p=1.000 n=1+1)
RuntimeVMInvokeContractImperativeFib-4	13.4kB ± 0%	13.4kB ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/sema goos:linux goarch:amd64
SuperTypeInference/arrays-4	72.0B ± 0%	72.0B ± 0%	~	(all equal)
SuperTypeInference/composites-4	0.00B	0.00B	~	(all equal)
SuperTypeInference/integers-4	0.00B	0.00B	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ValueIsSubtypeOfSemaType-4	32.0B ± 0%	32.0B ± 0%	~	(all equal)

	allocs/op		delta
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ByteArrayTransfer-4	7.00 ± 0%	7.00 ± 0%	~	(all equal)
ByteArrayValueToByteSlice-4	1.00 ± 0%	1.00 ± 0%	~	(all equal)
ByteSliceToByteArrayValue-4	5.00 ± 0%	5.00 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/bbq/compiler goos:linux goarch:amd64
CompileFungibleTokenTransferTransaction-4	576 ± 0%	576 ± 0%	~	(all equal)
CompileTime-4	209 ± 0%	209 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ContractFunctionInvocation-4	2.25k ± 0%	2.25k ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
ContractImport-4	1.29k ± 0%	1.29k ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
EMVAddressTransfer-4	29.0 ± 0%	29.0 ± 0%	~	(all equal)
Emit-4	40.0k ± 0%	40.0k ± 0%	~	(all equal)
EnumTransfer-4	13.0 ± 0%	13.0 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ExportType/composite_type-4	3.00 ± 0%	3.00 ± 0%	~	(all equal)
ExportType/simple_type-4	0.00	0.00	~	(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
FTTransfer-4	1.40k ± 0%	1.40k ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/sema goos:linux goarch:amd64
FlowTokenContract-4	3.58k ± 0%	3.58k ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ImperativeFib-4	176 ± 0%	176 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
ImperativeFib-4	266 ± 0%	266 ± 0%	~	(all equal)
ImperativeFibNewCompilerNewVM-4	473 ± 0%	473 ± 0%	~	(all equal)
ImperativeFibNewVM-4	308 ± 0%	308 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
InterpretRecursionFib-4	17.7k ± 0%	17.7k ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
InterpreterFTTransfer-4	916 ± 0%	916 ± 0%	~	(all equal)
InterpreterImperativeFib-4	175 ± 0%	175 ± 0%	~	(all equal)
InterpreterNewStruct-4	418 ± 0%	418 ± 0%	~	(all equal)
MethodCall/concrete_type_method_call-4	354 ± 0%	354 ± 0%	~	(all equal)
MethodCall/interface_method_call-4	464 ± 0%	464 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
NewInterpreter/new_interpreter-4	15.0 ± 0%	15.0 ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-4	4.00 ± 0%	4.00 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
NewResource-4	951 ± 0%	951 ± 0%	~	(all equal)
NewStruct-4	388 ± 0%	388 ± 0%	~	(all equal)
NewStructRaw-4	30.0 ± 0%	30.0 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/sema goos:linux goarch:amd64
QualifiedIdentifierCreation/One_level-4	0.00	0.00	~	(all equal)
QualifiedIdentifierCreation/Three_levels-4	2.00 ± 0%	2.00 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/bbq/vm/test goos:linux goarch:amd64
RecursionFib-4	15.8k ± 0%	15.8k ± 0%	~	(all equal)
RuntimeFungibleTokenTransfer-4	4.09k ± 0%	4.09k ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
RuntimeFungibleTokenTransferInterpreter-4	3.08k ± 0%	3.08k ± 0%	~	(all equal)
RuntimeFungibleTokenTransferVM-4	3.61k ± 0%	3.61k ± 0%	~	(all equal)
RuntimeResourceDictionaryValues-4	36.7k ± 0%	36.7k ± 0%	~	(all equal)
RuntimeResourceTracking-4	129k ± 0%	129k ± 0%	~	(p=1.000 n=1+1)
RuntimeScriptNoop-4	114 ± 0%	114 ± 0%	~	(all equal)
RuntimeVMInvokeContractImperativeFib-4	426 ± 0%	426 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/sema goos:linux goarch:amd64
SuperTypeInference/arrays-4	3.00 ± 0%	3.00 ± 0%	~	(all equal)
SuperTypeInference/composites-4	0.00	0.00	~	(all equal)
SuperTypeInference/integers-4	0.00	0.00	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ValueIsSubtypeOfSemaType-4	1.00 ± 0%	1.00 ± 0%	~	(all equal)

codecov · 2026-04-20T20:35:19Z

Codecov Report

❌ Patch coverage is 87.23404% with 6 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
interpreter/value_bool.go	79.31%	6 Missing ⚠️

📢 Thoughts on this report? Let us know!

turbolent self-assigned this Apr 20, 2026

turbolent requested a review from SupunS as a code owner April 20, 2026 20:06

turbolent added the Feature label Apr 20, 2026

add Bool.toString()

95b8688

turbolent force-pushed the bastian/add-bool-tostring branch from 591e55d to 95b8688 Compare April 20, 2026 20:26

SupunS approved these changes Apr 20, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Bool.toString()#4477

Add Bool.toString()#4477
turbolent wants to merge 1 commit intomasterfrom
bastian/add-bool-tostring

turbolent commented Apr 20, 2026

Uh oh!

github-actions Bot commented Apr 20, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 20, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Apr 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

turbolent commented Apr 20, 2026

Description

Uh oh!

github-actions Bot commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Dependency Review

Scanned Files

Uh oh!

github-actions Bot commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchstat comparison

Uh oh!

codecov Bot commented Apr 20, 2026

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Apr 20, 2026 •

edited

Loading

github-actions Bot commented Apr 20, 2026 •

edited

Loading