Skip to content

Add RoundingRule enum and optional rounding parameter to Fix64/UFix64 conversion functions #4474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
turbolent wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add RoundingRule enum and optional rounding parameter to Fix64/UFix64 conversion functions #4474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aece6f2
add RoundingMode enum and optional rounding parameter to Fix64/UFix64…
turbolent Apr 18, 2026
3024cfe
rename RoundingMode to RoundingRule
turbolent Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion bbq/vm/builtin_globals.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,13 +228,21 @@ func init() {
for _, declaration := range interpreter.ConverterDeclarations {
// NOTE: declare in loop, as captured in closure below
convert := declaration.Convert
convertWithRounding := declaration.ConvertWithRounding

functionType := sema.BaseValueActivation.Find(declaration.Name).Type.(*sema.FunctionType)

var nativeFn interpreter.NativeFunction
if convertWithRounding != nil {
nativeFn = interpreter.NativeConverterFunctionWithRounding(convert, convertWithRounding)
} else {
nativeFn = interpreter.NativeConverterFunction(convert)
}

function := NewNativeFunctionValue(
declaration.Name,
functionType,
interpreter.NativeConverterFunction(convert),
nativeFn,
)
registerBuiltinFunction(function)

Expand Down
7 changes: 7 additions & 0 deletions bbq/vm/value_function.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,13 @@ func (v *NativeFunctionValue) GetMember(
)
}

func (v *NativeFunctionValue) SetField(name string, value interpreter.Value) {
if v.fields == nil {
v.fields = make(map[string]interpreter.Value)
}
v.fields[name] = value
}

func (*NativeFunctionValue) RemoveMember(_ interpreter.ValueTransferContext, _ string) interpreter.Value {
panic(errors.NewUnreachableError())
}
Expand Down
Loading
Loading