Fix AST walking

[turbolent]

Work towards #4470

Description

Port the fixes to the AST walking from @holyfuchs in onflow/cadence-tools#628 and fix remaining gaps.

---

• Targeted PR against master branch
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work
• Code follows the standards mentioned here
• Updated relevant documentation
• Re-reviewed Files changed in the Github PR explorer
• Added appropriate labels

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

[github-actions]

Benchstat comparison

• Base branch: onflow:master
• Base commit: c5052d7

Results

	old.txt	new.txt
	time/op		delta
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ByteArrayTransfer-4	1.32µs ± 0%	1.31µs ± 0%	~	(p=1.000 n=1+1)
ByteArrayValueToByteSlice-4	71.7ns ± 0%	72.6ns ± 0%	~	(p=1.000 n=1+1)
ByteSliceToByteArrayValue-4	1.07µs ± 0%	1.00µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ContractFunctionInvocation-4	343µs ± 0%	333µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
EMVAddressTransfer-4	3.53µs ± 0%	3.60µs ± 0%	~	(p=1.000 n=1+1)
Emit-4	4.56ms ± 0%	4.74ms ± 0%	~	(p=1.000 n=1+1)
EnumTransfer-4	1.38µs ± 0%	1.50µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ExportType/composite_type-4	304ns ± 0%	304ns ± 0%	~	(p=1.000 n=1+1)
ExportType/simple_type-4	67.7ns ± 0%	66.8ns ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ImperativeFib-4	22.2µs ± 0%	23.5µs ± 0%	~	(p=1.000 n=1+1)
InterpretRecursionFib-4	2.19ms ± 0%	2.28ms ± 0%	~	(p=1.000 n=1+1)
NewInterpreter/new_interpreter-4	867ns ± 0%	893ns ± 0%	~	(p=1.000 n=1+1)
NewInterpreter/new_sub-interpreter-4	333ns ± 0%	344ns ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
RuntimeFungibleTokenTransferInterpreter-4	589µs ± 0%	593µs ± 0%	~	(p=1.000 n=1+1)
RuntimeFungibleTokenTransferVM-4	662µs ± 0%	687µs ± 0%	~	(p=1.000 n=1+1)
RuntimeResourceDictionaryValues-4	2.60ms ± 0%	2.61ms ± 0%	~	(p=1.000 n=1+1)
RuntimeResourceTracking-4	9.10ms ± 0%	9.18ms ± 0%	~	(p=1.000 n=1+1)
RuntimeScriptNoop-4	14.6µs ± 0%	14.6µs ± 0%	~	(p=1.000 n=1+1)
RuntimeVMInvokeContractImperativeFib-4	37.8µs ± 0%	37.8µs ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ValueIsSubtypeOfSemaType-4	54.2ns ± 0%	56.3ns ± 0%	~	(p=1.000 n=1+1)
	alloc/op		delta
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ByteArrayTransfer-4	1.02kB ± 0%	1.08kB ± 0%	~	(p=1.000 n=1+1)
ByteArrayValueToByteSlice-4	32.0B ± 0%	32.0B ± 0%	~	(all equal)
ByteSliceToByteArrayValue-4	871B ± 0%	853B ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ContractFunctionInvocation-4	144kB ± 0%	144kB ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
EMVAddressTransfer-4	2.45kB ± 0%	2.46kB ± 0%	~	(p=1.000 n=1+1)
Emit-4	1.49MB ± 0%	1.50MB ± 0%	~	(p=1.000 n=1+1)
EnumTransfer-4	827B ± 0%	832B ± 0%	~	(p=1.000 n=1+1)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ExportType/composite_type-4	120B ± 0%	120B ± 0%	~	(all equal)
ExportType/simple_type-4	0.00B	0.00B	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ImperativeFib-4	8.30kB ± 0%	8.30kB ± 0%	~	(all equal)
InterpretRecursionFib-4	1.19MB ± 0%	1.19MB ± 0%	~	(p=1.000 n=1+1)
NewInterpreter/new_interpreter-4	976B ± 0%	976B ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-4	232B ± 0%	232B ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
RuntimeFungibleTokenTransferInterpreter-4	165kB ± 0%	165kB ± 0%	~	(p=1.000 n=1+1)
RuntimeFungibleTokenTransferVM-4	188kB ± 0%	188kB ± 0%	~	(p=1.000 n=1+1)
RuntimeResourceDictionaryValues-4	1.76MB ± 0%	1.76MB ± 0%	~	(p=1.000 n=1+1)
RuntimeResourceTracking-4	6.97MB ± 0%	6.97MB ± 0%	~	(p=1.000 n=1+1)
RuntimeScriptNoop-4	8.09kB ± 0%	8.08kB ± 0%	~	(p=1.000 n=1+1)
RuntimeVMInvokeContractImperativeFib-4	13.4kB ± 0%	13.4kB ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ValueIsSubtypeOfSemaType-4	32.0B ± 0%	32.0B ± 0%	~	(all equal)
	allocs/op		delta
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ByteArrayTransfer-4	7.00 ± 0%	7.00 ± 0%	~	(all equal)
ByteArrayValueToByteSlice-4	1.00 ± 0%	1.00 ± 0%	~	(all equal)
ByteSliceToByteArrayValue-4	5.00 ± 0%	5.00 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ContractFunctionInvocation-4	2.25k ± 0%	2.25k ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
EMVAddressTransfer-4	29.0 ± 0%	29.0 ± 0%	~	(all equal)
Emit-4	40.0k ± 0%	40.0k ± 0%	~	(all equal)
EnumTransfer-4	13.0 ± 0%	13.0 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
ExportType/composite_type-4	3.00 ± 0%	3.00 ± 0%	~	(all equal)
ExportType/simple_type-4	0.00	0.00	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ImperativeFib-4	176 ± 0%	176 ± 0%	~	(all equal)
InterpretRecursionFib-4	17.7k ± 0%	17.7k ± 0%	~	(all equal)
NewInterpreter/new_interpreter-4	15.0 ± 0%	15.0 ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-4	4.00 ± 0%	4.00 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/runtime goos:linux goarch:amd64
RuntimeFungibleTokenTransferInterpreter-4	3.08k ± 0%	3.08k ± 0%	~	(all equal)
RuntimeFungibleTokenTransferVM-4	3.61k ± 0%	3.61k ± 0%	~	(all equal)
RuntimeResourceDictionaryValues-4	36.7k ± 0%	36.7k ± 0%	~	(all equal)
RuntimeResourceTracking-4	129k ± 0%	129k ± 0%	~	(all equal)
RuntimeScriptNoop-4	114 ± 0%	114 ± 0%	~	(all equal)
RuntimeVMInvokeContractImperativeFib-4	426 ± 0%	426 ± 0%	~	(all equal)
pkg:github.com/onflow/cadence/interpreter goos:linux goarch:amd64
ValueIsSubtypeOfSemaType-4	1.00 ± 0%	1.00 ± 0%	~	(all equal)