Re-use FVM benchmark transactions for interpreter/vm.#4355
Open
Re-use FVM benchmark transactions for interpreter/vm.#4355
Conversation
Benchstat comparison
Results
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
RZhang05
force-pushed
the
raymond/add-benchmarks
branch
from
d45498d to
7df0cfa
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Dependency ReviewThe following issues were found:
License Issuesgo.mod
OpenSSF Scorecard
Scanned Files
|
SupunS
reviewed
Dec 3, 2025
Member
SupunS
left a comment
SupunS
left a comment
There was a problem hiding this comment.
Nice work adding these unified benchmarks!
Comment on lines
+28
to
+29
| flowsdk "github.com/onflow/flow-go-sdk" | ||
| "github.com/onflow/flow-go-sdk/crypto" |
Member
There was a problem hiding this comment.
Is there a way to avoid the circular dependency here (i.e: flow-go-sdk imports cadence) to avoid any complications that we might run into when releasing? Could we maybe have these test as a sub-module, or maybe in a separate repo?
Contributor
Author
There was a problem hiding this comment.
Yeah I thought I removed all circular dependencies, maybe for simplicity I can port the signUserMessage function to this test file instead of creating a separate module/repo.
Member
There was a problem hiding this comment.
yeah, that's a good idea, if thats easier 👍
Contributor
Author
There was a problem hiding this comment.
I realized since the verification for the crypto related functionality is currently a NO-OP in the runtime interface, we can just use placeholder values instead of generating valid ones. 5747fa7
|
|
||
| b.StopTimer() | ||
| require.NoError(b, err) | ||
| b.StartTimer() |
Member
There was a problem hiding this comment.
Why does it need to start the timer b.StartTimer() here and stop it at the beginning of the loop? Can't we simply remove both?
Contributor
Author
There was a problem hiding this comment.
The stopTimer at the beginning of the loop is to account for setup time so that one should stay. This pair of stop/startTimer is just for the error check but could probably be removed. b.Loop() requires the timer to be running at the end which is why there is this startTimer here.
Co-authored-by: Supun Setunga <supun.setunga@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4329
Description
Takes ~5 minutes for combined inter and vm benchmarks to complete.
inter (master) vs vm (master)
inter(master) vs vm (supun/subtype-gen-runtime)
vm(master) vs vm (supun/subtype-gen-runtime)
masterbranchFiles changedin the Github PR explorer